Skip to content

Conversation

@patapenka-alexey
Copy link
Contributor

@patapenka-alexey patapenka-alexey commented Nov 10, 2025

Closes #TNTP-4171

@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-4171-signer-verifier branch 7 times, most recently from 7dce61d to 679b87b Compare November 10, 2025 13:12
@coveralls
Copy link

coveralls commented Nov 10, 2025

Pull Request Test Coverage Report for Build 19289323901

Details

  • 30 of 53 (56.6%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 23.077%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crypto/rsa.go 26 37 70.27%
marshaller/marshaller.go 0 12 0.0%
Totals Coverage Status
Change from base Build 19101577872: 1.0%
Covered Lines: 414
Relevant Lines: 1794

💛 - Coveralls

@patapenka-alexey patapenka-alexey marked this pull request as ready for review November 11, 2025 07:26
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-4171-signer-verifier branch 2 times, most recently from b433eb8 to 809bb94 Compare November 11, 2025 13:33
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-4171-signer-verifier branch 5 times, most recently from dc443ff to 7431a15 Compare November 12, 2025 07:08
@bigbes bigbes requested a review from oleg-jukovec November 12, 2025 10:14
@bigbes
Copy link
Collaborator

bigbes commented Nov 12, 2025

Last thing: add tests for running without privkey, pubkey and both pubkey/privkey.

  1. without privkey is needed to check that verification only works and signer will return error
  2. without pubkey - signer will work and verification wont.
  3. without both of them - none of the above operations will work.

@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-4171-signer-verifier branch from 7431a15 to 09d6eef Compare November 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants