Skip to content

Fix not necessary url_escape in cookie #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2019
Merged

Fix not necessary url_escape in cookie #82

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7cfb522
Merge pull request #1 from tarantool/master
norguhtar May 16, 2019
accf960
FIX cookie uri_escape was unnecessary
May 16, 2019
11a0630
Update http-1.0.2-1.rockspec
Admira1Awesome May 16, 2019
f03a3ec
Revert changes from our fork
May 17, 2019
3f64db6
Revert local changes
May 17, 2019
d6d7a9d
Revert local changes
May 17, 2019
1c8c9b2
Remove double quotation mark in Expries in Set-Cookie. It not need
May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions http/server.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,14 +279,14 @@ local function setcookie(resp, cookie)

local str = sprintf('%s=%s', name, uri_escape(value))
if cookie.path ~= nil then
str = sprintf('%s;path=%s', str, uri_escape(cookie.path))
str = sprintf('%s;path=%s', str, cookie.path)
end
if cookie.domain ~= nil then
str = sprintf('%s;domain=%s', str, cookie.domain)
end

if cookie.expires ~= nil then
str = sprintf('%s;expires="%s"', str, expires_str(cookie.expires))
str = sprintf('%s;expires=%s', str, expires_str(cookie.expires))
end

if not resp.headers then
Expand Down