docs: set_export documentation #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasiliy-t
suggested changes
Feb 1, 2021
yngvar-antonsson
force-pushed
the
set-export-docs
branch
from
793a5f3 to
d11e5e4
Compare
vasiliy-t
approved these changes
Feb 1, 2021
README.md
Outdated
| ``` | ||
| **OR** | ||
| Use `set_export`: |
Contributor
There was a problem hiding this comment.
I suggest to move set_export usage up and instead of 3. After role initialization. metrics are not exposed without set_export call until metrics role initialised and clusterwide config applied. set_export call is not optional but must have in init.lua. Also I suggest documenting 4. To view metrics via API endpoints, as an optional method of runtime configuration because it is not required in case when set_export is used.
vasiliy-t
approved these changes
Feb 4, 2021
yngvar-antonsson
force-pushed
the
set-export-docs
branch
from
6facc03 to
4b9947c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't forget about
Close #179