Fix old leader annotation #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanyarock01
force-pushed
the
fix-old-leader-annotation
branch
from
26c00fb to
81c2fc3
Compare
vanyarock01
added a commit
that referenced
this pull request
Feb 20, 2021
vanyarock01
force-pushed
the
fix-old-leader-annotation
branch
from
81c2fc3 to
758210e
Compare
vasiliy-t
suggested changes
Feb 20, 2021
vanyarock01
force-pushed
the
fix-old-leader-annotation
branch
from
758210e to
68493b1
Compare
vasiliy-t
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that, when changing cluster IP addresses, the cluster leader will not be re-elected.It may happen that it will be impossible to reach the leader's IP address.
There are two ways to solve the problem:
The first method is ideologically more correct, but requires backward compatibility support. This also requires more significant changes to the controller logic.
So I suggest using the second way.