From 441a2dd3b4552ac18d37f0b245af5a9ef63b30fb Mon Sep 17 00:00:00 2001
From: Mergen Imeev <imeevma@tarantool.org>
Date: Thu, 11 Apr 2024 15:04:15 +0300
Subject: [PATCH] connpool: fix connection error description

This patch corrects the connection error description in
"experimental.connpool.connect()".

NO_DOC=fix error description
NO_CHANGELOG=fix error description
---
 src/box/lua/experimental/connpool.lua |  4 ++--
 test/config-luatest/rpc_test.lua      | 10 ++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/box/lua/experimental/connpool.lua b/src/box/lua/experimental/connpool.lua
index fdc6c759163d..54fdc772eaf7 100644
--- a/src/box/lua/experimental/connpool.lua
+++ b/src/box/lua/experimental/connpool.lua
@@ -49,8 +49,8 @@ local function connect(instance_name, opts)
     -- If opts.wait_connected is not false we wait until the connection is
     -- established or an error occurs (including a timeout error).
     if opts.wait_connected ~= false and conn:wait_connected() == false then
-        local msg = 'Unable to connect to instance %q: connection timeout'
-        error(msg:format(instance_name), 0)
+        local msg = 'Unable to connect to instance %q: %s'
+        error(msg:format(instance_name, conn.error), 0)
     end
     return conn
 end
diff --git a/test/config-luatest/rpc_test.lua b/test/config-luatest/rpc_test.lua
index 40bed364b9e1..857e4792c21e 100644
--- a/test/config-luatest/rpc_test.lua
+++ b/test/config-luatest/rpc_test.lua
@@ -42,6 +42,9 @@ g.test_connect = function(g)
                 database:
                   mode: rw
               instance-004: {}
+          replicaset-003:
+            instances:
+              instance-005: {}
     ]]
     treegen.write_script(dir, 'config.yaml', config)
 
@@ -54,6 +57,8 @@ g.test_connect = function(g)
     g.server_2 = server:new(fun.chain(opts, {alias = 'instance-002'}):tomap())
     g.server_3 = server:new(fun.chain(opts, {alias = 'instance-003'}):tomap())
     g.server_4 = server:new(fun.chain(opts, {alias = 'instance-004'}):tomap())
+    -- The instance-005 instance is not started to check if the correct error
+    -- is returned.
 
     g.server_1:start({wait_until_ready = false})
     g.server_2:start({wait_until_ready = false})
@@ -90,6 +95,11 @@ g.test_connect = function(g)
         t.assert(conn2 == connpool.connect('instance-002'))
         t.assert(conn3 == connpool.connect('instance-003'))
         t.assert(conn4 == connpool.connect('instance-004'))
+
+        local ok, err = pcall(connpool.connect, 'instance-005')
+        t.assert_not(ok)
+        t.assert(err:startswith('Unable to connect to instance "instance-005"'))
+        t.assert(err:endswith('No such file or directory'))
     end
 
     g.server_1:exec(check_conn)