Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: convert to Tarantool coding style #3315

Closed
Gerold103 opened this issue Apr 4, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@Gerold103
Copy link
Collaborator

commented Apr 4, 2018

See src/box/sql/sqliteInt.h. The new prefix can be SQL_, for example.

Gerold103 added a commit that referenced this issue Apr 4, 2018

sql: light error codes refactoring
Remove unused error codes, use enum instead of
defines. Later the prefix SQLITE_ must be removed -
see #3315.
@Korablev77

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2018

Moreover, some of them SQLite specific and can be removed (alongside with code which uses it).

kyukhin added a commit that referenced this issue Apr 5, 2018

sql: light error codes refactoring
Remove unused error codes, use enum instead of
defines. Later the prefix SQLITE_ must be removed -
see #3315.

@kyukhin kyukhin added this to the 2.1.1 milestone Jul 5, 2018

Morgan-iv added a commit that referenced this issue Oct 2, 2018

sql: refactor SQLITE_IOERR_ error codes
Remove error codes with prefix SQLITE_IOERR_ that only defined,
but don't used anywhere.
Replace '#define' macro with enum statement in implementation of
SQLITE_IOERR_ error codes
Remove unused function xDelete from sqlite3_vfs interface and its
implementation, unixDelete. Also remove function openDirectory, used
only in unixDelete

Part of #3315

Morgan-iv added a commit that referenced this issue Oct 2, 2018

sql: remove unused SQLITE_CONSTRAINT_ error codes
Remove SQLITE_CONSTRAINT_ error codes that only defined, but don't used
anywhere. Change its implementation from define macro to enum statement.

Part of #3315

@kyukhin kyukhin modified the milestones: 2.1.1, 2.2.0 Dec 3, 2018

@kostja

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

The branch is obsolete, as is the ticket.

@kostja kostja closed this Feb 11, 2019

@kostja kostja changed the title sql: remove SQLITE_ prefix from error codes sql: convert to Tarantool coding style Feb 11, 2019

@kostja kostja reopened this Feb 11, 2019

@kyukhin

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

Done by 73e85ae

@kyukhin kyukhin closed this Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.