Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix luacheck warnings in test/sql-tap #5464

Closed
ligurio opened this issue Oct 29, 2020 · 2 comments
Closed

Fix luacheck warnings in test/sql-tap #5464

ligurio opened this issue Oct 29, 2020 · 2 comments
Assignees
@ligurio
Labels
lua luacheck
Milestone
2.8.1

Comments

@ligurio
Copy link
Member

ligurio commented Oct 29, 2020

No description provided.

@ligurio ligurio added the lua label Oct 29, 2020
@ligurio ligurio self-assigned this Oct 29, 2020
@ligurio ligurio mentioned this issue Oct 29, 2020
Closed
@Totktonada
Copy link
Member

Let's consider it as follow up of #5173 and #5181.

artemreyt added a commit that referenced this issue Nov 9, 2020
@artemreyt
luacheck: change global vars to local in sql-tap
d646730 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111.

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added inline comments for luacheck.

In .luacheckrc added all lua files, which where checked before
this commit, to `include_files` option and cleaned almost totally
option `exclude_files`.

It was bad idea to add deep directories to `exclude_files`, because
after that there is no way to enable files or child dirs of this
directory for processing by luacheck. In this case, it was impossible
to enable `test/sql-tap/` directory because whole `test/` was in
`exclude_files` and consequently ignored.

Fixes #5173
Part-of #5464
artemreyt added a commit that referenced this issue Nov 12, 2020
@artemreyt
luacheck: change global vars to local in sql-tap
d44244b 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111.

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added inline comments for luacheck.

In .luacheckrc added all lua files, which where checked before
this commit, to `include_files` option and cleaned almost totally
option `exclude_files`.

It was bad idea to add deep directories to `exclude_files`, because
after that there is no way to enable files or child dirs of this
directories for processing by luacheck. In this case, it was impossible
to enable `test/sql-tap/` directory because whole `test/` was in
`exclude_files` and consequently ignored.

Fixes #5173
Part-of #5464
artemreyt added a commit that referenced this issue Nov 20, 2020
@artemreyt
luacheck: change global vars to local in sql-tap
9fa9abe 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added inline comments for luacheck.

Fixes #5173
Part-of #5464
artemreyt added a commit that referenced this issue Nov 26, 2020
@artemreyt
luacheck: change global vars to local in sql-tap
9e57f52 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added inline comments for luacheck.

Fixes #5173
Part-of #5464
artemreyt added a commit that referenced this issue Dec 14, 2020
@artemreyt
luacheck: change global vars to local in sql-tap
6356f57 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added explicit _G. prefix (table of globals).

Fixes #5173
Part-of #5464
kyukhin pushed a commit that referenced this issue Dec 16, 2020
@artemreyt @kyukhin
luacheck: change global vars to local in sql-tap
f87e715 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added explicit _G. prefix (table of globals).

Fixes #5173
Part-of #5464

(cherry picked from commit b1a4fed)
kyukhin pushed a commit that referenced this issue Dec 16, 2020
@artemreyt @kyukhin
luacheck: change global vars to local in sql-tap
b1a4fed 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added explicit _G. prefix (table of globals).

Fixes #5173
Part-of #5464
kyukhin pushed a commit that referenced this issue Dec 16, 2020
@artemreyt @kyukhin
luacheck: change global vars to local in sql-tap
6397518 
Fixed luacheck warning 111 (setting non-standard global variable)
in test/sql-tap directory.
Enabled this directory for checking W111 in
config file(.luacheckrc).

Changed almost all variables in test/sql-tap from globals
to locals. In any cases, where variables need to be global,
added explicit _G. prefix (table of globals).

Fixes #5173
Part-of #5464

(cherry picked from commit b1a4fed)
ligurio added a commit that referenced this issue Jan 13, 2021
@ligurio @Gerold103 @igormunkin
test: fix luacheck warnings in test/sql-tap
97a73ec 
Closes #5464

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Jan 13, 2021
@ligurio @Gerold103 @igormunkin
test: fix luacheck warnings in test/sql-tap
ea6dcfb 
Closes #5464

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
@ligurio
Copy link
Member Author

ligurio commented Jan 14, 2021

[Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/sql and test/sql-tap
https://lists.tarantool.org/pipermail/tarantool-patches/2021-January/021949.html

ligurio added a commit that referenced this issue Jan 15, 2021
@ligurio @Gerold103 @igormunkin
test: fix luacheck warnings in test/sql-tap
35e7486 
Closes #5464

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Jan 15, 2021
@ligurio @Gerold103 @igormunkin
test: fix luacheck warnings in test/sql-tap
de23b70 
Closes #5464

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
luacheck: ignore broken sql-tap tests
a08a851 
Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W113)
c6a4876 
W113 (Accessing an undefined global variable)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W211)
8ca1cbe 
W211 (Unused local variable)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W212)
dd6fc16 
W212 (Unused argument)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix laucheck warnings in test/sql-tap (W213)
1ca2bd6 
W213 (Unused loop variable)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W231)
0d08951 
W231 (Local variable is set but never accessed)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W311)
e782c3a 
W311 (Value assigned to a local variable is unused)

Part of #5464
ligurio added a commit that referenced this issue Jan 20, 2021
@ligurio
test: fix luacheck warnings in test/sql-tap (W511)
79f5b45 
W511 (Unreachable code)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W542 in test/sql-tap
bf9e486 
W542 (An empty if branch)

Part of #5464

(cherry picked from commit 8f3b9b4)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W612, W613, W614 in test/sql-tap
da40262 
W612 (A line contains trailing whitespace)
W613 (Trailing whitespace in a string)
W614 (Trailing whitespace in a comment)

Note: changes were made automatically in vim with regexp "%s/\s\+$//e".

Part of #5464

(cherry picked from commit fc94ac4)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W621 in test/sql-tap
c97e0bb 
W621 (Inconsistent indentation (SPACE followed by TAB))

Part of #5464

(cherry picked from commit 99219d6)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
luacheck: add issue for suppressed W631 warning
c90524f 
Closes #5464

(cherry picked from commit 9a12cd3)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: remove functions to open and close SQL connection
a3cf076 
Part of #5464
Closes #5741
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W113 in test/sql-tap
4e7e099 
W113 (Accessing an undefined global variable)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W211 in test/sql-tap
25582a5 
W211 (Unused local variable)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W212 in test/sql-tap
9026532 
W212 (Unused argument)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix laucheck warnings W213 in test/sql-tap
0843b24 
W213 (Unused loop variable)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W231 in test/sql-tap
1952d7b 
W231 (Local variable is set but never accessed)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W311 in test/sql-tap
136c682 
W311 (Value assigned to a local variable is unused)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W511 in test/sql-tap
7f93432 
W511 (Unreachable code)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W512 in test/sql-tap
6f2a7ba 
W512 (Loop can be executed at most once)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W542 in test/sql-tap
8f3b9b4 
W542 (An empty if branch)

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W612, W613, W614 in test/sql-tap
fc94ac4 
W612 (A line contains trailing whitespace)
W613 (Trailing whitespace in a string)
W614 (Trailing whitespace in a comment)

Note: changes were made automatically in vim with regexp "%s/\s\+$//e".

Part of #5464
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W621 in test/sql-tap
99219d6 
W621 (Inconsistent indentation (SPACE followed by TAB))

Part of #5464
@kyukhin kyukhin closed this as completed in 9a12cd3 Mar 2, 2021
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: remove functions to open and close SQL connection
e2bf0b9 
Part of #5464
Closes #5741

(cherry picked from commit a3cf076)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W113 in test/sql-tap
e3c6359 
W113 (Accessing an undefined global variable)

Part of #5464

(cherry picked from commit 4e7e099)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W211 in test/sql-tap
2f0052d 
W211 (Unused local variable)

Part of #5464

(cherry picked from commit 25582a5)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W212 in test/sql-tap
3bef57e 
W212 (Unused argument)

Part of #5464

(cherry picked from commit 9026532)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix laucheck warnings W213 in test/sql-tap
214681f 
W213 (Unused loop variable)

Part of #5464

(cherry picked from commit 0843b24)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W231 in test/sql-tap
9e180e6 
W231 (Local variable is set but never accessed)

Part of #5464

(cherry picked from commit 1952d7b)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W311 in test/sql-tap
73c4b2b 
W311 (Value assigned to a local variable is unused)

Part of #5464

(cherry picked from commit 136c682)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W511 in test/sql-tap
919cf5e 
W511 (Unreachable code)

Part of #5464

(cherry picked from commit 7f93432)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W512 in test/sql-tap
180e190 
W512 (Loop can be executed at most once)

Part of #5464

(cherry picked from commit 6f2a7ba)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W542 in test/sql-tap
150b8d5 
W542 (An empty if branch)

Part of #5464

(cherry picked from commit 8f3b9b4)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W612, W613, W614 in test/sql-tap
0f2e754 
W612 (A line contains trailing whitespace)
W613 (Trailing whitespace in a string)
W614 (Trailing whitespace in a comment)

Note: changes were made automatically in vim with regexp "%s/\s\+$//e".

Part of #5464

(cherry picked from commit fc94ac4)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
test: fix luacheck warnings W621 in test/sql-tap
056b265 
W621 (Inconsistent indentation (SPACE followed by TAB))

Part of #5464

(cherry picked from commit 99219d6)
kyukhin pushed a commit that referenced this issue Mar 2, 2021
@ligurio @kyukhin
luacheck: add issue for suppressed W631 warning
1a5976c 
Closes #5464

(cherry picked from commit 9a12cd3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ligurio ligurio

Labels
lua luacheck
Projects
None yet
Milestone
2.8.1
Development

No branches or pull requests
3 participants
@Totktonada @ligurio @kyukhin