New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix luacheck warnings in test/sql-tap #5464
Comments
artemreyt
added a commit
that referenced
this issue
Nov 9, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111. Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added inline comments for luacheck. In .luacheckrc added all lua files, which where checked before this commit, to `include_files` option and cleaned almost totally option `exclude_files`. It was bad idea to add deep directories to `exclude_files`, because after that there is no way to enable files or child dirs of this directory for processing by luacheck. In this case, it was impossible to enable `test/sql-tap/` directory because whole `test/` was in `exclude_files` and consequently ignored. Fixes #5173 Part-of #5464
artemreyt
added a commit
that referenced
this issue
Nov 12, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111. Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added inline comments for luacheck. In .luacheckrc added all lua files, which where checked before this commit, to `include_files` option and cleaned almost totally option `exclude_files`. It was bad idea to add deep directories to `exclude_files`, because after that there is no way to enable files or child dirs of this directories for processing by luacheck. In this case, it was impossible to enable `test/sql-tap/` directory because whole `test/` was in `exclude_files` and consequently ignored. Fixes #5173 Part-of #5464
artemreyt
added a commit
that referenced
this issue
Nov 20, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added inline comments for luacheck. Fixes #5173 Part-of #5464
artemreyt
added a commit
that referenced
this issue
Nov 26, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added inline comments for luacheck. Fixes #5173 Part-of #5464
artemreyt
added a commit
that referenced
this issue
Dec 14, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added explicit _G. prefix (table of globals). Fixes #5173 Part-of #5464
kyukhin
pushed a commit
that referenced
this issue
Dec 16, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added explicit _G. prefix (table of globals). Fixes #5173 Part-of #5464 (cherry picked from commit b1a4fed)
kyukhin
pushed a commit
that referenced
this issue
Dec 16, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added explicit _G. prefix (table of globals). Fixes #5173 Part-of #5464
kyukhin
pushed a commit
that referenced
this issue
Dec 16, 2020
Fixed luacheck warning 111 (setting non-standard global variable) in test/sql-tap directory. Enabled this directory for checking W111 in config file(.luacheckrc). Changed almost all variables in test/sql-tap from globals to locals. In any cases, where variables need to be global, added explicit _G. prefix (table of globals). Fixes #5173 Part-of #5464 (cherry picked from commit b1a4fed)
ligurio
added a commit
that referenced
this issue
Jan 13, 2021
Closes #5464 Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Reviewed-by: Igor Munkin <imun@tarantool.org> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio
added a commit
that referenced
this issue
Jan 13, 2021
Closes #5464 Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Reviewed-by: Igor Munkin <imun@tarantool.org> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Co-authored-by: Igor Munkin <imun@tarantool.org>
[Tarantool-patches] [PATCH v7 0/2] Fix luacheck warnings in test/sql and test/sql-tap |
ligurio
added a commit
that referenced
this issue
Jan 15, 2021
Closes #5464 Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Reviewed-by: Igor Munkin <imun@tarantool.org> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio
added a commit
that referenced
this issue
Jan 15, 2021
Closes #5464 Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Reviewed-by: Igor Munkin <imun@tarantool.org> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W113 (Accessing an undefined global variable) Part of #5464
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W211 (Unused local variable) Part of #5464
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W213 (Unused loop variable) Part of #5464
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W231 (Local variable is set but never accessed) Part of #5464
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W311 (Value assigned to a local variable is unused) Part of #5464
ligurio
added a commit
that referenced
this issue
Jan 20, 2021
W511 (Unreachable code) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W113 (Accessing an undefined global variable) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W211 (Unused local variable) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W213 (Unused loop variable) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W231 (Local variable is set but never accessed) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W311 (Value assigned to a local variable is unused) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W511 (Unreachable code) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W512 (Loop can be executed at most once) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W542 (An empty if branch) Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W612 (A line contains trailing whitespace) W613 (Trailing whitespace in a string) W614 (Trailing whitespace in a comment) Note: changes were made automatically in vim with regexp "%s/\s\+$//e". Part of #5464
kyukhin
pushed a commit
that referenced
this issue
Mar 2, 2021
W621 (Inconsistent indentation (SPACE followed by TAB)) Part of #5464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: