Skip to content

Conversation

@Elishtar
Copy link
Contributor

@Elishtar Elishtar commented Nov 10, 2022

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #60
Closes #58

@Elishtar Elishtar force-pushed the fix_debendency_conflicts branch from 60b2da7 to faae825 Compare November 10, 2022 10:00
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot, add some words in changelog. Also add Closes #58 in commit/PR description

@Elishtar
Copy link
Contributor Author

Done

@ArtDu ArtDu force-pushed the fix_debendency_conflicts branch from c37c2b2 to 3aad183 Compare November 10, 2022 14:41
@ArtDu
Copy link
Contributor

ArtDu commented Nov 10, 2022

@Elishtar I fixed like I wanted it. If you don't mind I'll merge it

@Elishtar Elishtar merged commit 55d0c2d into master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dependency management Bump dependencies with vulnerabilities

3 participants