Conversation
migrate config from .eslintrc.json and .eslintignore to eslint.config.js
humphd
requested changes
Oct 7, 2024
Collaborator
humphd
left a comment
There was a problem hiding this comment.
Excellent. Those catch(err) issues could be converted to not require the disable.
Collaborator
|
Cloudflare build fails like so: |
Deploying chatcraft-org with
|
| Latest commit: |
6ff346a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3bde30ed.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://issue-689.console-overthinker-dev.pages.dev |
Collaborator
Author
This is because I upgraded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #689
This PR upgrades Eslint to v9 and moves to a flat config.
All plugins are now up to date and compatible with the new Eslint flat config. The exception was
eslint-plugin-react-hookswhere I had to use the latest rc version (facebook/react#28313 (comment)).I started the upgrade process with the configuration migrator and then went through each plugin and used the recommended configuration setup found in the docs (while making sure all the original chatcraft custom configurations are kept).