Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum for GFALL_AIR_THRESHOLD #203

Open
epassaro opened this issue Dec 12, 2020 · 3 comments
Open

Use enum for GFALL_AIR_THRESHOLD #203

epassaro opened this issue Dec 12, 2020 · 3 comments
Labels
feature priority-low

Comments

@epassaro
Copy link
Member

Description
@hrithik18236
Copy link

hrithik18236 commented Mar 26, 2021 •
edited
Loading

@epassaro GFALL_AIR_THRESHOLD is given a value of 200 in the file /carsus/io/output/base.py. Are P_EMISSION_DOWN, P_INTERNAL_DOWN and P_INTERNAL_UP part of GFALL_AIR_THRESHOLD so that I may include them in the enum GFALL_AIR_THRESHOLD?

@chvogl
Copy link
Contributor

chvogl commented Mar 29, 2021

@hrithik18236 The P_EMISSION_DOWN etc. have nothing to do with the GFALL_AIR_THRESHOLD. They are relevant for how Carsus/Tardis treats atomic transitions in the macro atom scheme.

@hrithik18236
Copy link

@chvogl Alright! So what attributes should the enum GFALL_AIR_THRESHOLD have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature priority-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chvogl @andrewfullard @epassaro @hrithik18236