Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module and notebook for the pipeline (CMFGEN to HDF5) #143

Merged
merged 20 commits into from Jul 23, 2019

Conversation

@epassaro
Copy link
Contributor

epassaro commented Jul 16, 2019

carsus/io/cmfgen/hdfgen.py Outdated Show resolved Hide resolved
carsus/io/cmfgen/hdfgen.py Outdated Show resolved Hide resolved
@epassaro epassaro changed the title Notebook for the pipeline (CMFGEN to HDF5) Module and notebook for the pipeline (CMFGEN to HDF5) Jul 19, 2019
@epassaro epassaro requested a review from wkerzendorf Jul 19, 2019
def hdf_dump(cmfgen_dir, patterns, parser, chunk_size=10, ignore_patterns=[]):
"""Function to parse and dump the entire CMFGEN database.
Arguments:

This comment has been minimized.

Copy link
@wkerzendorf

wkerzendorf Jul 22, 2019

Member

this needs to be numpydoc style.

This comment has been minimized.

Copy link
@epassaro

epassaro Jul 22, 2019

Author Contributor

Oh, I did it with the VSCode plugin, I'll try to configure it.

epassaro added 2 commits Jul 22, 2019
@wkerzendorf wkerzendorf merged commit c31827e into tardis-sn:master Jul 23, 2019
7 checks passed
7 checks passed
Carsus Tests Build #20190723.1 succeeded
Details
Carsus Tests (Test coverage) Test coverage succeeded
Details
Carsus Tests (Test database) Test database succeeded
Details
Carsus Tests (Test remote_data) Test remote_data succeeded
Details
Carsus Tests (Test simple) Test simple succeeded
Details
Carsus Tests (Test slow) Test slow succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.