Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIST parser new HDF output #144

Merged
merged 17 commits into from Aug 16, 2019

Conversation

@epassaro
Copy link
Contributor

epassaro commented Jul 16, 2019

Copy link
Member

wkerzendorf left a comment

please fix ;-)

carsus/io/nist/ionization.py Outdated Show resolved Hide resolved
carsus/io/nist/weightscomp.py Outdated Show resolved Hide resolved
docs/io/nist/nist_weights_comp.ipynb Show resolved Hide resolved
from carsus.io.util import to_nom_val_and_std_dev
from carsus.util.helpers import ATOMIC_SYMBOLS_DATA
from carsus.io.nist.weightscomp_grammar import isotope, COLUMNS, ATOM_NUM_COL, MASS_NUM_COL,\

This comment has been minimized.

Copy link
@marxwillia

marxwillia Aug 16, 2019

PEP8 line length.

This comment has been minimized.

Copy link
@epassaro

epassaro Aug 16, 2019

Author Contributor

I didn't touch any previous existing code, applied PEP8 standards to my changes only. There are a LOT of long lines!

from carsus.io.nist.weightscomp import (download_weightscomp,
NISTWeightsCompPyparser,

This comment has been minimized.

Copy link
@marxwillia

marxwillia Aug 16, 2019

Make indentation consistent with above line.

@chvogl chvogl merged commit e3cd1ca into tardis-sn:master Aug 16, 2019
7 checks passed
7 checks passed
Carsus Tests Build #20190815.1 succeeded
Details
Carsus Tests (Test coverage) Test coverage succeeded
Details
Carsus Tests (Test database) Test database succeeded
Details
Carsus Tests (Test remote_data) Test remote_data succeeded
Details
Carsus Tests (Test simple) Test simple succeeded
Details
Carsus Tests (Test slow) Test slow succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.