Updating the config reader to work with the validator #136
Conversation
…ord to go - particularly important for paper1_tardis_configv1.yml
| type: | ||
| property_type: container-declaration | ||
| containers: ['branch85_w7'] | ||
| +branch85_w7: ['time_0', 'density_coefficient'] |
There was a problem hiding this comment.
@mklauser does this work, not having any mandatory things in there?
… in Container -> recursive_parser
bug fix for the container handling. ToDo Remove remove general except in...
…l except removed for testing.
Conflicts: tardis/io/config_validator.py
…rf/tardis into config/using_definition_parser
Conflicts: tardis/data/tardis_config_definition.yml
Conflicts: tardis/io/tests/test_config_reader.py
|
@mklauser @ssim Can you please run tardis with this version and see if you get the same results. This is ready for merge now (if @orbitfold can run it and see if it works that would be great as well!!) |
wkerzendorf
changed the title
…nition_parser Conflicts: docs/conf.py tardis/io/config_validator.py
|
@orbitfold @ssim please look over this and merge (or give go ahead) after TRAVIS passes. |
|
@wkerzendorf Travis fails - are you looking into it? |
|
@ssim, yes it's a problem with our convergence section. the last travis (running a full simulation) caught that - I'm pretty happy with that addition. |
|
@wkerzendorf - ok! - I leave it in your capable hands then! |
|
@ssim - sure let's pretend (for now) I'm capable. |
|
@ssim this should be ready now and merge able. |
|
Merging now! |
Updating the config reader to work with the validator
This PR now updates the config validator to be used in the regular TARDIS runs.