Caching #9
Merged
Caching #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would start using more (sub-)packages, because there are so many files in the composition-package now. I think it is becoming confusing if you want to look at the code for the first time. |
| @@ -0,0 +1,357 @@ | |||
| // Automatically generated by MockGen. DO NOT EDIT! | |||
There was a problem hiding this comment.
This file should not be committed, the other file is enough.
|
+1, it is easy to understand, but i did not have time to test it locally (so i just read it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the caching pull request to start reviewing.