fix(hotstuff): fix bug where decide state was listening for wrong mes…

…sage (#4160) Description --- Fixes the decide state listening for the wrong message type Motivation and Context --- I noticed that views were timing out and that the decide state would log "Already received this message". This was happening because the leader would read the message that the replica was meant to, and then the replica would miss the message and the state would time out How Has This Been Tested? --- Manually
tari-project · Jun 6, 2022 · fe7b304 · fe7b304
1 parent 736ec3e
commit fe7b304
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/applications/launchpad/gui-react/build/.gitkeep b/applications/launchpad/gui-react/build/.gitkeep
diff --git a/dan_layer/core/src/models/hot_stuff_message.rs b/dan_layer/core/src/models/hot_stuff_message.rs
@@ -172,7 +172,7 @@ impl<TPayload: Payload> HotStuffMessage<TPayload> {
         asset_public_key: PublicKey,
     ) -> Self {
         Self {
-            message_type: HotStuffMessageType::Commit,
+            message_type: HotStuffMessageType::Decide,
             node,
             justify: commit_qc,
             view_number,

diff --git a/dan_layer/core/src/models/mod.rs b/dan_layer/core/src/models/mod.rs
@@ -165,6 +165,7 @@ pub enum HotStuffMessageType {
     Prepare,
     PreCommit,
     Commit,
+    Decide,
     // Special type
     Genesis,
 }
@@ -176,6 +177,7 @@ impl HotStuffMessageType {
             HotStuffMessageType::Prepare => 2,
             HotStuffMessageType::PreCommit => 3,
             HotStuffMessageType::Commit => 4,
+            HotStuffMessageType::Decide => 5,
             HotStuffMessageType::Genesis => 255,
         }
     }
@@ -190,6 +192,7 @@ impl TryFrom<u8> for HotStuffMessageType {
             2 => Ok(HotStuffMessageType::Prepare),
             3 => Ok(HotStuffMessageType::PreCommit),
             4 => Ok(HotStuffMessageType::Commit),
+            5 => Ok(HotStuffMessageType::Decide),
             255 => Ok(HotStuffMessageType::Genesis),
             _ => Err("Not a value message type".to_string()),
         }

diff --git a/dan_layer/core/src/workers/states/decide_state.rs b/dan_layer/core/src/workers/states/decide_state.rs
@@ -85,7 +85,7 @@ impl<TSpecification: ServiceSpecification> DecideState<TSpecification> {
                       }
                   }
                 },
-              r = inbound_services.wait_for_qc(HotStuffMessageType::Prepare, current_view.view_id()) => {
+              r = inbound_services.wait_for_qc(HotStuffMessageType::Commit, current_view.view_id()) => {
                     let (from, message) = r?;
                     let leader= self.committee.leader_for_view(current_view.view_id).clone();
                       if let Some(event) = self.process_replica_message(&message, current_view, &from, &leader, &mut unit_of_work, payload_provider).await? {