feat: constitution publishing #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
constitution-publish
branch
from
4988306
to
a2b908d
Compare
brianp
force-pushed
the
constitution-publish
branch
from
a2b908d
to
8da58a0
Compare
|
I think it's worth changing all the old "committee definition" terminology for the newer "contract constitution" everywhere, to avoid name inconsistency. Otherwise, LGTM |
brianp
force-pushed
the
constitution-publish
branch
from
c2785d6
to
2f4b8aa
Compare
SWvheerden
reviewed
Jun 3, 2022
applications/tari_console_wallet/src/grpc/wallet_grpc_server.rs
Outdated
Show resolved
Hide resolved
brianp
force-pushed
the
constitution-publish
branch
from
c2a4d82
to
6788a6e
Compare
sdbondi
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the committee proposals into constitution publishing.
Motivation and Context
Meet the new requirements for proposing a committee. Update old code to match new specifications. Refactor the existing functionality instead of introducing net new functionality.
It may have been a better choice to specify a json file as a constitution but I wanted to keep similar functionality to how it was being done. By the end of the PR this was obviously a less ideal choice. We accept 4 arguments to create the constitution at the moment. Where as there are more arguments that can be utilized.
How Has This Been Tested?
cargo run --bin tari_console_wallet -- -b . --command "publish-constitution-definition --json-file ../../integration_tests/fixtures/constitution_definition.json"