Add optional fee_per_gram field to console wallet Send Tx form #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipr-za
force-pushed
the
philip-console-edit-fee
branch
from
450c783
to
17b31ef
Compare
|
Added a quick update to not quit on a plain 'q' but to quit on ctrl+q and ctrl+c |
delta1
suggested changes
Nov 5, 2020
This PR adds an optional editable fee_per_gram field to the send transaction form in the console wallet. This field is populated by the default value specified by a constant in LibWallet and is not included in the flow of fields edited while sending a transaction as editing this field should be very rare. If the user wants to edit the field they can use the hotkey and after this transaction is sent the field will be repopulated with the default value again. This functionality was not able to be tested as the network is currently experiencing some issues that make sending transactions difficult.
philipr-za
force-pushed
the
philip-console-edit-fee
branch
from
17b31ef
to
2008472
Compare
|
Fixed, though issue came from development. Thou shalt appease clippy! |
|
yeah I blame @mikethetike 😆 |
StriderDM
reviewed
Nov 6, 2020
| use tari_crypto::common::Blake256; | ||
|
|
||
| /// The default fee per gram that the wallet will use to build transactions. | ||
| /// TODO discuss what the default fee value should actually be | ||
| pub const DEFAULT_FEE_PER_GRAM: MicroTari = MicroTari(25); |
There was a problem hiding this comment.
Minimum fee in mobile wallet is set to 100.
Not sure if these should be in sync?
There was a problem hiding this comment.
This is fee_per_gram not absolute fee. This is also an arb selection and needs to be discussed as stated in the TODO
stringhandler
approved these changes
Nov 9, 2020
stringhandler
added a commit
that referenced
this pull request
Nov 24, 2020
Major changes since v0.6.0 --- - [#2431](#2431) Database refactor to remove checkpoints and more efficient calculation of MMR roots - [#2352](#2352) Add DNS seed support in base node Minor changes since v0.6.0 --- - [#2448](#2448) Add OpenSSL to Windows install, runtime - [#2434](#2434) Add supervisord setup notes - [#2439](#2439) Provide initial sync status to merge mining proxy - [#2377](#2377) Message malleability detect and ban - [#2447](#2447) Fix for xmrig powershell script - [#2440](#2440) Stagenet Setup Guide Corrections - [#2444](#2444) DHT connectivity waits for comms connectivity before starting - [#2427](#2427) Update merge mining runtime, README, Win install - [#2420](#2420) Show base node chain tip and sync status in the console wallet - [#2419](#2419) Add optional fee_per_gram field to console wallet Send Tx form - [#2421](#2421) Fix QR code rendering in the console wallet - [#2423](#2423) Plumb in the balance in the console wallet - [#2415](#2415) Prevent loop in peer sync by storing all peers attempted - [#2383](#2383) Implement daemon-mode in tari_base_node - [#2407](#2407) Simplify automated stress test - [#2397](#2397) Fix preset config files - [#2400](#2400) Implement wallet base node service - [#2403](#2403) Add exclusive file locks to Wallet, Chain and Peer db’s - [#2408](#2408) Fix wallet conversion error for a valid tx status - [#2356](#2356) Combine validation code to use same function in pruned and archive mode. - [#2371](#2371) Add configurable BN service request timeouts - [#2430](#2430) Implement entry and persistence of custom base node in console wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional editable fee_per_gram field to the send transaction form in the console wallet.
This field is populated by the default value specified by a constant in LibWallet and is not included in the flow of fields edited while sending a transaction as editing this field should be very rare. If the user wants to edit the field they can use the hotkey and after this transaction is sent the field will be repopulated with the default value again.
How Has This Been Tested?
This functionality was not able to be tested as the network is currently experiencing some issues that make sending transactions difficult.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.