Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp encryption code for stibbons #2571

Merged

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Jan 28, 2021

Description

This removes the older code of that creates a physical file on disc for the wallets. This is for Stibbons reset.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@hansieodendaal
Copy link
Contributor

LGTM

hansieodendaal
hansieodendaal previously approved these changes Jan 28, 2021
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified, nice. Tested.

merge conflicts

remove tor
@stringhandler stringhandler merged commit f8421bb into tari-project:development Feb 3, 2021
@SWvheerden SWvheerden deleted the sw_removewallettestcode branch February 4, 2021 20:48
stringhandler added a commit that referenced this pull request Feb 5, 2021
- [#2618](#2618) [console-wallet] Implement WalletNotify for console wallet TUI mode
- [#2615](#2615) [base-node] Cucumber test for GRPC method relating to block explorer
- [#2590](#2590) [console-wallet] Add filter to exclude not yet mature utxo's from transaction creation
- [#2611](#2611) [chore] Fix tests
- [#2609](#2609) [base-node] Restore get_network_difficulty GRPC method
- [#2610](#2610) [console-wallet] View QR code on console wallet on low res screens
- [#2604](#2604) [base-node] Move capping of target difficulty
- [#2607](#2607) [chore] Fix tests
- [#2601](#2601) [chore] Add seed node names to preset config
- [#2600](#2600) [chore] Remove unmaintained bigint dep
- [#2598](#2598) [tests] Fix tests breaking due to Fee vs Sent amount validation
- [#2599](#2599) [tests] Add cucumber integration test txn status
- [#2571](#2571) [chore] Remove test net temp code
- [#2570](#2570) [chore] Wallet db migration cleanup
- [#2596](#2596) [base-node] Update default pruning horizon to 1000
- [#2480](#2480) [docs] Update pool mining on mainnet readme
- [#2597](#2597) [console-wallet] Add TXO validation to console wallet
- [#2595](#2595) [MM_Proxy] Submit to origin daemon configuration
- [#2593](#2593) Added Wallet Identify GRPC Methods, updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants