Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting not running on certain reports #154

Closed
ganeshn-gh opened this issue Feb 15, 2024 · 2 comments
Closed

Linting not running on certain reports #154

ganeshn-gh opened this issue Feb 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ganeshn-gh
Copy link

Here is a report where the linter did not run: https://github.com/tarides/admin/commits/main/weekly/2024/01/Kate.md. There is no tick or cross mark

image

Usually there is one. For example,

image

Please can we identify why the linter does not run on certain reports and make sure they run on all the submitted reports.

@ganeshn-gh ganeshn-gh added the bug Something isn't working label Feb 15, 2024
@punchagan
Copy link
Member

punchagan commented Feb 15, 2024

Here is a report where the linter did not run: https://github.com/tarides/admin/commits/main/weekly/2024/01/Kate.md. There is no tick or cross mark

GitHub actions run only per "push", rather than per commit. So, when a push has two commits, the GitHub action's status icon will only be shown on the last commit in the push.

In the example you provided, the lint was performed on the commit after the one in your example. And here is the result of the lint run for the report highlighted in your screenshot. (You can click on Run okra-lint and see that the FILES variable includes the 01/Kate.md file)

@ganeshn-gh
Copy link
Author

Yeah, I got it. Thanks @punchagan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants