Update from Ori #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #26 ``` File "C:\Users\James Pollack\Desktop\gpt-2\src\encoder.py", line 112, in get_encoder bpe_data = f.read() File "C:\Anaconda\envs\gpt-2\lib\encodings\cp1252.py", line 23, in decode return codecs.charmap_decode(input,self.errors,decoding_table)[0] UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 66951: character maps to <undefined>```
This PR adds better initial parameters to the conditional sample generation command in the docs. The results are pretty poor in the interactive script with the default settings. Now, you'll get better results if you run the interactive samples.
…ve LF line endings and all files stay unix on commit
Add note about setting PYTHONIOENCODING=UTF-8 env var for running examples
Example will `tee` stdout to `/tmp/samples` from conditional and unconditional generation scripts.
add description for flags
added python download script and modified requirements to add the modules needed. Tested in Windows Version 10.0.17134 Build 17134 and Ubuntu 18.04.1 LTS
This write-up was loosely inspired in part by Mitchell et al.’s work on [Model Cards for Model Reporting](https://arxiv.org/abs/1810.03993). Adding such model usage sections could be good practice in general for open source research projects with potentially broad applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.