Highlighting regression

[bbatsov]

See:

That's my config:

(use-package hl-todo
  :ensure t
  :config
  (setq hl-todo-highlight-punctuation ":")
  (global-hl-todo-mode))

[tarsius]

I can't reproduce that.

[bbatsov]

Happens for me all the time. My exact setup is here https://github.com/bbatsov/emacs.d (if you'd like to try with it).

[bbatsov]

Hmm, seems it's specific to Clojure mode. But I'm pretty certain this used to work in Clojure mode just fine.

[tarsius]

I was just gonna ask about the major-mode 😜

[tarsius]

What is the syntax of :? describe-char will show you.

[bbatsov]

It's symbol.

[tarsius]

As in emacs-lisp-mode. Must be something else then.

hl-todo-next, which uses the same regexp, is able to find TODO:.

[tarsius]

Still it has something to do with syntax, specifically this: (("+-*/.<>=!?$%_&:" . "w")) in clojure-font-lock-setup. Removing that fixes things.

[tarsius]

Well the issue was what I though it was, except that I had now idea that some major-modes had a font-lock syntax table that is different from the major-mode syntax-table.

[bbatsov]

Thanks!

Maybe we've messed something up in clojure-mode. There's a lot of legacy there that I never got to cleaning up.

[tarsius]

And some low-hanging fruit:

Compiling /home/jonas/.emacs.d/lib/clojure-mode/clojure-mode.el...

In toplevel form:
clojure-mode.el:476:1:Warning: Unused lexical argument ‘args’
clojure-mode.el:476:1:Warning: Unused lexical argument ‘orig-fun’

In clojure--replace-let-bindings-and-indent:
clojure-mode.el:487:12:Warning: looking-back called with 1 argument, but
    requires 2-3
clojure-mode.el:2023:1:Warning: Unused lexical variable
    ‘clojure-comment-start’
clojure-mode.el:2083:1:Warning: Unused lexical variable ‘beg’

In clojure-cycle-not:
clojure-mode.el:2426:10:Warning: looking-back called with 1 argument, but
    requires 2-3
clojure-mode.el:2640:1:Warning: Unused lexical variable ‘k’

😜

looking-back called with 1 argument, but requires 2-3 at least must be fixed.

[tarsius]

Maybe we've messed something up in clojure-mode.

Doesn't matter there will be other modes that need their syntax-table shadowed. I think with-syntax-table isn't too expensive anyway. I followed the c code along and it seems fairly harmless.