This repository has been archived by the owner on May 9, 2020. It is now read-only.
Bug 1447985 - limit format of supersederUrl #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walac
suggested changes
Mar 22, 2018
schemas/payload.json
Outdated
| @@ -242,7 +242,8 @@ | |||
| "supersederUrl": { | |||
| "title": "URL of the a service that can indicate tasks superseding this one; the current taskId will be appended as a query argument `taskId`. The service should return an object with a `supersedes` key containing a list of taskIds, including the supplied taskId. The tasks should be ordered such that each task supersedes all tasks appearing earlier in the list. See [superseding](https://docs.Taskcluster.net/reference/platform/taskcluster-queue/docs/superseding) for more detail.", | |||
| "type": "string", | |||
| "format": "uri" | |||
| "format": "uri", | |||
| "pattern": "^https?://[\\x20-\\x7e]$" | |||
There was a problem hiding this comment.
I think we missed a Kleene star here...
|
Fixed -- and I verified that this works (both for OK cases and bad unicode) with https://www.jsonschemavalidator.net/ |
walac
approved these changes
Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.