generate code for taskcluster.sync.* #46

Merged
merged 12 commits into from Mar 16, 2016

Projects

None yet

2 participants

@escapewindow
Contributor

This is a continuation of #45.

@escapewindow
Contributor

@jhford how does escapewindow@92d8006 look for dual integration tests?

I'm leaning towards splitting that out into a test_integration.py, but I don't feel strongly about it.

@escapewindow
Contributor

I thought I should mention, since I would wonder if I were in your position:

I wanted to have TestRuntimeAuthentication inherit TestAuthentication, only replacing the taskcluster.Auth class with a createApiClient class. That would be a lot neater and simpler. However, when I did that, nosetests didn't run any tests for TestRuntimeAuthentication.

Maybe there's a trick I don't know, but this was the way I got tests to run for both TestRuntimeAuthentication and TestBuildtimeAuthentication.

@jhford
Contributor
jhford commented Mar 9, 2016

Looks good! It might be possible to generate the test classes programmatically using the type function, (see createApiClient as example), but I don't think that's blocking. I'd like to take one more overall look at this a little later, but I don't expect there to be anything major.

Thanks for working on this!

@escapewindow
Contributor

@jhford, have you had a chance to take another look yet?

@jhford
Contributor
jhford commented Mar 15, 2016

Yep! Looks good. I'm going to merge this but hold off on releasing a new major version to send an email suggesting that users of the client library try it out and let us know if there are issues for them.

@jhford jhford merged commit 6cd24a8 into taskcluster:master Mar 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment