This repository was archived by the owner on Jan 5, 2019. It is now read-only.
This might fix what's been breaking auth tests #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/client.js
Outdated
| reportStats(true, 'http-' + res.status); | ||
| } | ||
| if(res.headers['content-type'].indexOf('application/json') === -1 || !res.body){ | ||
| if((_.includes(res.headers, 'content-type') && |
Contributor
There was a problem hiding this comment.
_.includes(res.headers, 'content-type') checks if there is a value called 'content-type', not if there is a key.
Either use _.includes(res.headers['content-type'], 'application/json') or do if (res.headers['content-type'] && res.headers['content-type'].indexOf(...
That's just my guess...
Contributor
There was a problem hiding this comment.
hmm... maybe I'm reading the docs wrong... Or are we missing some tests, because ideally this should be caught by travis...
Contributor
Author
|
Oops, you're totally right. This is the correct fix. |
Contributor
|
R+ |
Contributor
|
R+! Please land, release a new version, and update tc-tools to use that new version as a minimum. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta run now, this is messy, but is what we need to do to fix the broken auth tests.