From b74be0c21f3934244bfab5c5c95bf55e86c8e3c6 Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Mon, 26 Nov 2018 18:12:45 +0000 Subject: [PATCH 1/2] Bug 1509186 - remove references to taskcluster.net from API description --- src/exchanges.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/exchanges.js b/src/exchanges.js index 1e2ad04..74ef498 100644 --- a/src/exchanges.js +++ b/src/exchanges.js @@ -7,10 +7,9 @@ let exchanges = new Exchanges({ serviceName: 'hooks', apiVersion: 'v1', description: [ - 'The hooks service, typically available at `hooks.taskcluster.net`', - 'is responsible for creating tasks at specific times or in .', - 'response to webhooks and API calls.Using this exchange allows us', - 'to make hooks which repsond to particular pulse messages', + 'The hooks service is responsible for creating tasks at specific times or', + 'in . response to webhooks and API calls.Using this exchange allows us to', + 'make hooks which repsond to particular pulse messages', '', 'These exchanges provide notifications when a hook is created, updated', 'or deleted. This is so that the listener running in a different hooks ', From ca8d8fa81aa874a0b63523f4f5c86ab4eb684eba Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Mon, 26 Nov 2018 18:13:08 +0000 Subject: [PATCH 2/2] remove old comment --- schemas/v1/create-hook-request.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/schemas/v1/create-hook-request.yml b/schemas/v1/create-hook-request.yml index b8ff6b1..dc0696e 100644 --- a/schemas/v1/create-hook-request.yml +++ b/schemas/v1/create-hook-request.yml @@ -8,12 +8,6 @@ properties: hookId: {$const: hookId} metadata: {$ref: "hook-metadata.json#"} schedule: - # It would be prettier with: - # {$ref: "http://schemas.taskcluster.net/hooks/v1/schedule.json#"} - # but it breaks "default" handling, schema library is a bit sketchy when it - # come to the "default" keyword.. I'm looking at an alernative that is - # both faster and implements "default" correctly. - # (there corner cases with anyof, and $ref that isn't handled well.) description: | Definition of the times at which a hook will result in creation of a task. If several patterns are specified, tasks will be created at any time