This repository was archived by the owner on Jan 5, 2019. It is now read-only.
Ignore notifications on cancel #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbstack
reviewed
May 3, 2018
Contributor
imbstack
left a comment
imbstack
left a comment
There was a problem hiding this comment.
Looks good to me. I see that discussion of doing this in a more flexible way has moved to bugzilla!
p.s. Oh no, I just realized that taskcluster spells cancelled differently than I do!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how sane this is...
Maybe we should notify about cancel, since it's kind of important to know
if your release task was canceled by someone else...