From c9748b6010fb44f77c6a898e7a76f49de344bd74 Mon Sep 17 00:00:00 2001
From: Jonas Finnemann Jensen <jopsen@gmail.com>
Date: Thu, 3 May 2018 15:39:07 +0200
Subject: [PATCH] Ignore notifications on cancel

---
 docs/usage.md  |  4 ++--
 src/handler.js | 10 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/docs/usage.md b/docs/usage.md
index 9d5ed6b..ba1f3ff 100644
--- a/docs/usage.md
+++ b/docs/usage.md
@@ -16,13 +16,13 @@ __Pulse:__ We can also send a Pulse message that is documented [on this page](ht
 
 ### Filters
 
-__on-any:__ This does what it sounds like and will notify you of task-completion no matter how it ends.
+__on-any:__ This does what it sounds like and will notify you of task-completion no matter how it ends. Unless the task was deliberately canceled.
 
 __on-success:__ Only when the task completes with no errors will you get a notification.
 
 __on-failed:__ Only when the task fails for non-internal reasons will this be triggered. This could be your tests failing or a lint step failing, as examples.
 
-__on-exception:__ This is triggered when some sort of internal issue happens in Taskcluster and we had to cancel the task.
+__on-exception:__ This is triggered when the task didn't run due to some exception, internal error, timeouts, deadlines, malformed-payload; if the task was deliberately canceled notifications will not be sent.
 
 More thorough (and more correct) documentation of what task statuses are can be found [on the docs site](https://docs.taskcluster.net/reference/platform/queue/api-docs#status).
 
diff --git a/src/handler.js b/src/handler.js
index bb4a7c8..76b73c9 100644
--- a/src/handler.js
+++ b/src/handler.js
@@ -50,8 +50,15 @@ class Handler {
   }
 
   async onMessage(message) {
-    // Load task definition
     let {status} = message.payload;
+
+    // If task was canceled, we don't send a notification since this was a deliberate user action
+    if (status.state === 'exception' && (_.last(status.runs) || {}).reasonResolved === 'canceled') {
+      debug('Received message for %s with notify routes, ignoring because task was canceled', status.taskId);
+      return null;
+    }
+
+    // Load task definition
     let taskId = status.taskId;
     let task = await this.queue.task(taskId);
     let href = `https://tools.taskcluster.net/task-inspector/#${taskId}`;
@@ -137,4 +144,3 @@ Task [\`${taskId}\`](${href}) in task-group [\`${task.taskGroupId}\`](${groupHre
 
 // Export Handler
 module.exports = Handler;
-