Implement env plugin.#39
Conversation
| type: "object" | ||
| patternProperties: | ||
| .+: | ||
| type: string |
There was a problem hiding this comment.
Don't use pattern properties...
Just use additionalProperties: {type: string}
Also add some "description" properties, ideally with a description that can serve as documentation... It doesn't have to be long, but a line, two or 5 would be good. Usually using markdown in description properties is fine, we do it everywhere...
|
Why must |
Because they are hard to generate... there are pros/cons... but they aren't generated by |
walac
force-pushed
the
master
branch
2 times, most recently
from
60727d9 to
b7bbd32
Compare
|
Implementation changed based on what @petemoore, @jonasfj and I discussed. |
| for k, v := range self.payload { | ||
| err := sandboxBuilder.SetEnvironmentVariable(k, v) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Most errors here should be transformed to MalformedPayloadError see:
taskcluster-worker/engines/sandboxbuilder.go
Lines 64 to 73 in 2130156
Basically, ErrNamingConflict is a problem that can be solved by changing the task payload. The same is the case for ErrFeatureNotSupported, if env vars aren't support... user just shouldn't specify any...
There was a problem hiding this comment.
Errors other than the ones specified as "Non-fatal errors" in
taskcluster-worker/engines/sandboxbuilder.go
Lines 64 to 73 in 2130156
Can be passed through as you have no possible way to handle those gracefully. Thus they must be fatal.
env plugin is responsible to process the "env" section from the task payload. It setups environment variables inside the sandbox.
|
|
|
This looks awesome! Tests too! ++ |
3 participants
env plugin is responsible to process the section "env" from the task
payload. It setups environment variables inside the sandbox.