New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement env plugin. #39

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@walac
Contributor

walac commented Mar 8, 2016

env plugin is responsible to process the section "env" from the task
payload. It setups environment variables inside the sandbox.

@walac

This comment has been minimized.

Show comment
Hide comment
@walac

walac Mar 8, 2016

Contributor

Why must generated_*.go files be checked in?

Contributor

walac commented Mar 8, 2016

Why must generated_*.go files be checked in?

@jonasfj

This comment has been minimized.

Show comment
Hide comment
@jonasfj

jonasfj Mar 8, 2016

Contributor

Why must generated_*.go files be checked in?

Because they are hard to generate... there are pros/cons... but they aren't generated by go build so it's nice to do... especially because it prevents anyone from using it as a library..

Contributor

jonasfj commented Mar 8, 2016

Why must generated_*.go files be checked in?

Because they are hard to generate... there are pros/cons... but they aren't generated by go build so it's nice to do... especially because it prevents anyone from using it as a library..

@walac

This comment has been minimized.

Show comment
Hide comment
@walac

walac Mar 8, 2016

Contributor

Implementation changed based on what @petemoore, @jonasfj and I discussed.

Contributor

walac commented Mar 8, 2016

Implementation changed based on what @petemoore, @jonasfj and I discussed.

Show outdated Hide outdated plugins/env/env.go
Implement env plugin.
env plugin is responsible to process the "env" section from the task
payload. It setups environment variables inside the sandbox.
@jonasfj

This comment has been minimized.

Show comment
Hide comment
@jonasfj

jonasfj Mar 9, 2016

Contributor

r+

Contributor

jonasfj commented Mar 9, 2016

r+

@petemoore

This comment has been minimized.

Show comment
Hide comment
@petemoore

petemoore Mar 9, 2016

Member

This looks awesome! Tests too! ++

Member

petemoore commented Mar 9, 2016

This looks awesome! Tests too! ++

walac added a commit that referenced this pull request Mar 9, 2016

@walac walac merged commit 1587a61 into taskcluster:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment