Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Can't copy from scope expander #1211

Closed
djmitche opened this issue Aug 22, 2019 · 5 comments · Fixed by #1236

Comments

@djmitche
Copy link
Contributor

@djmitche djmitche commented Aug 22, 2019

Steps to reproduce:

@helfi92

This comment has been minimized.

Copy link
Member

@helfi92 helfi92 commented Aug 22, 2019

To fix this issue, we would need to stop using the button prop https://github.com/taskcluster/taskcluster/blob/master/ui/src/views/Scopes/ScopesetExpander/index.jsx#L87

and instead add a hover effect similar to the one used by a button to

taskcluster/ui/src/theme.js

Lines 159 to 170 in bb08a08

listItemButton: {
'& svg': {
transition: transitions.create('fill'),
fill: lighten(
isDarkTheme ? THEME.PRIMARY_TEXT_LIGHT : THEME.PRIMARY_TEXT_LIGHT,
0.4
),
},
'&:hover svg, &:focus svg': {
fill: textPrimary,
},
},

In the interest of maintaining consistency, we would need to look for all places where we use the button prop with the ListItem component and remove the button prop.

@rbrishabh

This comment has been minimized.

Copy link
Collaborator

@rbrishabh rbrishabh commented Aug 23, 2019

I would like to take this up!

@helfi92

This comment has been minimized.

Copy link
Member

@helfi92 helfi92 commented Aug 23, 2019

Go for it

@Hansolo-72

This comment has been minimized.

Copy link

@Hansolo-72 Hansolo-72 commented Aug 24, 2019

can I take this ?

@rbrishabh

This comment has been minimized.

Copy link
Collaborator

@rbrishabh rbrishabh commented Aug 24, 2019

Hi @Hansolo-72, I am already doing this! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.