Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form labels for check boxes might be misbehaving #1889

Open
rbrishabh opened this issue Nov 5, 2019 · 6 comments
Labels
bug

Comments

@rbrishabh
Copy link
Collaborator

@rbrishabh rbrishabh commented Nov 5, 2019

Describe the bug
For example, in taskcluster-ui.herokuapp.com/quickstart, clicking on checkboxes focuses the form label "This Task Should Run On" at irregular times.

ezgif com-video-to-gif

Steps to reproduce the behavior:

  1. Go to taskcluster-ui.herokuapp.com/quickstart,
  2. Scroll down to 'This Task Should Run On'
  3. Click on random checkboxes
  4. See error

Expected behavior
Form label doesn't change focus like this for checkboxes.

Currently
Form label keeps changing irregularly.

Additional context
The same actually does happen for Material UI Checkboxes and their labels as well. (https://material-ui.com/components/checkboxes/)
However, a simple fix would be to add global CSS to not let the label become focused on selecting a checkbox.

What do you think @helfi92. I would like to make a PR for this if you think this is an issue!

Thanks!

@rbrishabh rbrishabh added the bug label Nov 5, 2019
@helfi92

This comment has been minimized.

Copy link
Member

@helfi92 helfi92 commented Nov 5, 2019

Hm, if this is a material-ui bug, maybe we should a raise an issue upstream in material-ui repo. Is there an issue already open for this?

@rbrishabh

This comment has been minimized.

Copy link
Collaborator Author

@rbrishabh rbrishabh commented Nov 5, 2019

I don't think it's present there. I will create an issue there as well. Anyhow, would you like me to create a PR to fix this one? @helfi92

@helfi92

This comment has been minimized.

Copy link
Member

@helfi92 helfi92 commented Nov 5, 2019

Anyhow, would you like me to create a PR to fix this one? @helfi92

Not at the moment. Let's wait to hear back from material-ui folks first. Also, I noticed that this issue is only on Chrome, not Firefox.

@rbrishabh

This comment has been minimized.

Copy link
Collaborator Author

@rbrishabh rbrishabh commented Nov 5, 2019

Alright! I will let you know once I hear back from material-ui. Thanks!

@helfi92

This comment has been minimized.

Copy link
Member

@helfi92 helfi92 commented Nov 5, 2019

You can post a link to the issue here if that helps.

@rbrishabh

This comment has been minimized.

Copy link
Collaborator Author

@rbrishabh rbrishabh commented Nov 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.