Save filters in worker-manager UI

[ahal]

Describe the bug
The worker-manager UI loses its filter when you click "View Errors" / "View Workers" then go back again. This is a minor annoyance :)

To Reproduce

Steps to reproduce the behavior:

1. Go to 'https://firefox-ci-tc.services.mozilla.com/worker-manager'
2. Apply a filter (e.g gcp)
3. Click "View Errors" for one of the provisioniers
4. Go back
5. The GCP filter is lost and now you need to type it out again so you can inspect the next one.

Expected behavior
Would be nice if the filter were saved somehow (url parameter?) so I didn't have to re-type everything. My work around is to just always open the View Workers / View Errors pages in a new tab (but sometimes I forget).

Come to think of it, encoding the filter in the url would also make sharing links to specific workers better.

Taskcluster version
44.8.1

[lotas]

I guess we could simply put filter in the query string, so navigating back and forth would be logical and easy to share link
I don't think it makes sense to persist in some session storage filters for every page

[abdelquodr]

Hello @ahal and @lotas. I'll like to check on this issue. kindly assign it to me

[lotas]

Hi @abdelquodr! Sounds great, will assign!

[abdelquodr]

Thanks, @lotas. I'm On it.
But I'm unable to successfully run the repo on my local machine.
I'm running on Linux manjaro. and It has started compiling since yesternight and not done till now

[lotas]

What are you trying to compile?
For this issue you only need the ui component which can run independently and point https://community-tc.services.mozilla.com/

We didn't have this feature till now, but if you change targets here to the url above:

taskcluster/ui/.neutrinorc.js

Lines 61 to 78 in 8e8bc01

	proxy: {
	'/login': {
	target: 'http://localhost:3050',
	changeOrigin: true,
	},
	'/graphql': {
	target: 'http://localhost:3050',
	changeOrigin: true,
	},
	'/subscription': {
	ws: true,
	changeOrigin: true,
	target: 'ws://localhost:3050',
	},
	'/api/web-server': {
	target: 'http://localhost:3050',
	changeOrigin: true,
	},

you would be able to run the UI locally against community-tc.

cd ui
yarn install
yarn start

[abdelquodr]

Hello @lotas, followed your instructions and was able to successfully run it. Thanks

[abdelquodr]

I'm now presently working on it

[abdelquodr]

@lotas and @ahal. I'm done fixing the bug. and I'm open to feedback, comment, or suggestion on how to better my solution.
It's really an enjoyable journey for me.
I learned that you use Phabricator for code review. I wanna go through the docs and read and understand the basics before pushing for review.

Thanks, @lotas

[abdelquodr]

kindly let me know if I can use git.

Thanks

[djmitche]

@abdelquodr the Taskcluster codebase is in Git, so not using Phabricator -- that's only used for the Firefox codebase itself and a few other things. You can just make a "normal" GitHub PR.

[abdelquodr]

ok. thanks @djmitche

[abdelquodr]

can anyone pls help, I could not push to my local branches, I've tried all i could
i got === remote: Permission to taskcluster/taskcluster.git denied to abdelquodr.
fatal: unable to access 'https://github.com/taskcluster/taskcluster.git/': The requested URL returned error: 403

[matt-boris]

@abdelquodr please use a fork of the repo instead and make a PR with your fork.

[abdelquodr]

@matt-boris it works. thanks

[abdelquodr]

Hello @matt-boris ad @djmitche. what is my contribution url link as an outreachy applicant please?

[petemoore]

I'm very sorry @abdelquodr I don't think taskcluster is participating in Outreachy for this round.

[saigoud25]

can I work on this issue?

[lotas]

@saigoud25 sure, feel free to contribute!

[saigoud25]

hey @lotas while trying to reproduce the same issue on my local host I have got this error when opened this url http://localhost:5080/worker-manager

can you help me to get out it?

And what are the credentials for sign in?

[lotas]

@saigoud25 please check the network inspector tab to see what is the exact error
Also, how did you start the server? If you didn't provide taskcluster root url, it would talk to localhost:3050, and if nothing is running there, chances are it is going to fail like this.

Try

TASKCLUSTER_ROOT_URL=https://community-tc.services.mozilla.com yarn start