Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created confirmation dialog before deleting hook #1068

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@rbrishabh
Copy link
Collaborator

rbrishabh commented Jul 18, 2019

Fixes #957
@helfi92

Before: No confirmation dialog on deleting hook.

After:

is this ok

Confirmation dialog box comes first on deleting hook.

Let me know if this needs any changes!
Thank you! :)

@rbrishabh rbrishabh requested a review from taskcluster/frontend-reviewers as a code owner Jul 18, 2019
@helfi92 helfi92 force-pushed the rbrishabh:bug-1 branch from a08bbac to be878ef Jul 18, 2019
Copy link
Member

helfi92 left a comment

Thank you so much. I added a small patch on top to fix a small issue but other than that, it was really good 💯

@helfi92 helfi92 merged commit 1856274 into taskcluster:master Jul 18, 2019
44 of 46 checks passed
44 of 46 checks passed
Header rules - taskcluster-web No header rules processed
Details
Pages changed - taskcluster-web 4 new files uploaded
Details
Mixed content - taskcluster-web No mixed content detected
Details
Redirect rules - taskcluster-web 3 redirect rules processed
Details
codecov/patch Coverage not affected when comparing 6438f6f...be878ef
Details
codecov/project 86% (-1%) compared to 6438f6f
Details
lint Taskcluster (pull_request)
Details
netlify/taskcluster-web/deploy-preview Deploy preview ready!
Details
taskcluster-auth Taskcluster (pull_request)
Details
taskcluster-built-in-workers Taskcluster (pull_request)
Details
taskcluster-client Taskcluster (pull_request)
Details
taskcluster-client-go-1.12.6 Taskcluster (pull_request)
Details
taskcluster-client-py-2.7 Taskcluster (pull_request)
Details
taskcluster-client-py-3.6 Taskcluster (pull_request)
Details
taskcluster-client-py-3.7 Taskcluster (pull_request)
Details
taskcluster-client-shell-1.12.6 Taskcluster (pull_request)
Details
taskcluster-client-web Taskcluster (pull_request)
Details
taskcluster-github Taskcluster (pull_request)
Details
taskcluster-hooks Taskcluster (pull_request)
Details
taskcluster-index Taskcluster (pull_request)
Details
taskcluster-lib-api Taskcluster (pull_request)
Details
taskcluster-lib-app Taskcluster (pull_request)
Details
taskcluster-lib-azure Taskcluster (pull_request)
Details
taskcluster-lib-config Taskcluster (pull_request)
Details
taskcluster-lib-iterate Taskcluster (pull_request)
Details
taskcluster-lib-loader Taskcluster (pull_request)
Details
taskcluster-lib-monitor Taskcluster (pull_request)
Details
taskcluster-lib-pulse Taskcluster (pull_request)
Details
taskcluster-lib-references Taskcluster (pull_request)
Details
taskcluster-lib-scopes Taskcluster (pull_request)
Details
taskcluster-lib-testing Taskcluster (pull_request)
Details
taskcluster-lib-validate Taskcluster (pull_request)
Details
taskcluster-login Taskcluster (pull_request)
Details
taskcluster-notify Taskcluster (pull_request)
Details
taskcluster-purge-cache Taskcluster (pull_request)
Details
taskcluster-queue Taskcluster (pull_request)
Details
taskcluster-secrets Taskcluster (pull_request)
Details
taskcluster-terraform Taskcluster (pull_request)
Details
taskcluster-treeherder Taskcluster (pull_request)
Details
taskcluster-ui Taskcluster (pull_request)
Details
taskcluster-web-server Taskcluster (pull_request)
Details
taskcluster-worker-manager Taskcluster (pull_request)
Details
test:meta Taskcluster (pull_request)
Details
upload-coverage Taskcluster (pull_request)
Details
yarn build Taskcluster (pull_request)
Details
yarn generate Taskcluster (pull_request)
Details
@rbrishabh

This comment has been minimized.

Copy link
Collaborator Author

rbrishabh commented Jul 19, 2019

I saw the changes you did as well.

I thought it was okay to use the same props of DialogOpen dialog for DeleteDialogOpen dialog for handling cases of dialog close, dialog error etc as well.

I understood that it also has to be different. Got the general trend! (y) Thank you again.

And you're welcome!

I would be around here to contribute more, so if I can be of any service, just tag me! :D

@helfi92

This comment has been minimized.

Copy link
Member

helfi92 commented Jul 19, 2019

Nice. Are you interested in #1073? Comment on the bug directly if you are :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.