Switch UI test runner from karma to jest - #5163
Merged
Merged
Conversation
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
February 10, 2022 11:34
lotas
force-pushed
the
ui/introduce-unit-tests
branch
from
February 11, 2022 13:47
239afe6 to
1dee2b4
Compare
Jest is a perfect candidate to do component integration and snapshot testing.
They are blacklisted from running
lotas
force-pushed
the
ui/introduce-unit-tests
branch
from
February 11, 2022 14:41
555cc5b to
5c66fc8
Compare
lotas
changed the title
matt-boris
reviewed
Feb 14, 2022
matt-boris
left a comment
matt-boris
left a comment
Contributor
There was a problem hiding this comment.
I feel we should also remove the cypress examples before merging to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest will allow to write better integration and snapshot tests for react components
Related to: https://mozilla-hub.atlassian.net/browse/FCP-25