Tweaking numbers and adding preStop hook to make sure no connections are lost#6718
Merged
Tweaking numbers and adding preStop hook to make sure no connections are lost#6718
preStop hook to make sure no connections are lost#6718Conversation
are lost Tested on dev and this seems to give best result with zero connections being lost after manually scaling up and down during load testing. Without lifecycle hook connections were still dropping, but with it none.
lotas
requested review from
matt-boris and
petemoore
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on dev and this seems to give best result with zero connections being lost after manually scaling up and down during load testing. Without lifecycle hook connections were still dropping, but with it none.