From fa3ea9888aace7eb22ab48a52cec4e7e55259a9f Mon Sep 17 00:00:00 2001 From: Ben Hearsum Date: Wed, 19 Jun 2024 20:26:12 -0400 Subject: [PATCH 1/2] fix: make IndexSearch optimization log reasons why it may refuse to use a replacement task --- src/taskgraph/optimize/strategies.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/taskgraph/optimize/strategies.py b/src/taskgraph/optimize/strategies.py index ad4903aa0..414d0cbab 100644 --- a/src/taskgraph/optimize/strategies.py +++ b/src/taskgraph/optimize/strategies.py @@ -49,11 +49,13 @@ def should_replace_task(self, task, params, deadline, arg): # status can be `None` if we're in `testing` mode # (e.g. test-action-callback) if not status or status.get("state") in ("exception", "failed"): + logger.debug(f'not replacing {task["label"]} with {task_id} because it is in failed or exception state') continue if deadline and datetime.strptime( status["expires"], self.fmt ) < datetime.strptime(deadline, self.fmt): + logger.debug(f'not replacing {task["label"]} with {task_id} because it expires before {deadline}') continue return task_id From 9b5e89c372fae912a2b8abae0bd73cf91d88f740 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 20 Jun 2024 00:40:19 +0000 Subject: [PATCH 2/2] style: pre-commit.ci auto fixes [...] --- src/taskgraph/optimize/strategies.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/taskgraph/optimize/strategies.py b/src/taskgraph/optimize/strategies.py index 414d0cbab..621e28aa9 100644 --- a/src/taskgraph/optimize/strategies.py +++ b/src/taskgraph/optimize/strategies.py @@ -49,13 +49,17 @@ def should_replace_task(self, task, params, deadline, arg): # status can be `None` if we're in `testing` mode # (e.g. test-action-callback) if not status or status.get("state") in ("exception", "failed"): - logger.debug(f'not replacing {task["label"]} with {task_id} because it is in failed or exception state') + logger.debug( + f'not replacing {task["label"]} with {task_id} because it is in failed or exception state' + ) continue if deadline and datetime.strptime( status["expires"], self.fmt ) < datetime.strptime(deadline, self.fmt): - logger.debug(f'not replacing {task["label"]} with {task_id} because it expires before {deadline}') + logger.debug( + f'not replacing {task["label"]} with {task_id} because it expires before {deadline}' + ) continue return task_id