Fix delete lock move waiting children #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Apr 26, 2022
| @@ -21,7 +21,15 @@ | |||
| ]] | |||
| local rcall = redis.call | |||
|
|
|||
| local function move_to_waiting_children (activeKey, waitingChildrenKey, jobId, timestamp) | |||
| local function move_to_waiting_children (activeKey, waitingChildrenKey, jobId, timestamp, lockKey, token) | |||
| if token ~= "0" then | |||
There was a problem hiding this comment.
moved here as we are checking the jobKey existence first in other scripts
manast
reviewed
Apr 26, 2022
| @@ -21,7 +21,15 @@ | |||
| ]] | |||
| local rcall = redis.call | |||
|
|
|||
| local function move_to_waiting_children (activeKey, waitingChildrenKey, jobId, timestamp) | |||
| local function move_to_waiting_children (activeKey, waitingChildrenKey, jobId, timestamp, lockKey, token) | |||
There was a problem hiding this comment.
This function is not following the naming convention we used for other functions, i.e. camel case.
There was a problem hiding this comment.
you're right, changed in last commit
manast
approved these changes
Apr 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# [1.81.0](v1.80.6...v1.81.0) (2022-04-26) ### Features * **move-to-delayed:** allow passing token ([#1213](#1213)) ([14f0e4a](14f0e4a))
|
🎉 This PR is included in version 1.81.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1115