Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid changing Job property types through JSON serialization/deserialization #70 #74

Merged
merged 2 commits into from Nov 21, 2019

Conversation

@jbr
Copy link
Contributor

jbr commented Nov 20, 2019

renames Job#toJSON to Job#asJSON and adds a test

renames Job#toJSON to Job#asJSON and adds a test
Copy link
Contributor

manast left a comment

Thanks for the patch, seems like in node 8, the new test creates a circular dependency, too late for me to dig more into this:
image

@jbr

This comment has been minimized.

Copy link
Contributor Author

jbr commented Nov 20, 2019

@manast 5752727 strips out the queue from JSON serialization, which is probably what people would want when serializing a Job. It might also make sense just to remove the test and leave the toJSON→asJSON rename, since JSON serialization of Jobs isn't necessarily part of the supported API.

@jbr jbr changed the title fix: avoid the .toJSON serializer interface #70 fix: avoid changing Job property types through JSON serialization/deserialization #70 Nov 20, 2019
@manast
manast approved these changes Nov 21, 2019
@manast manast merged commit 344a887 into taskforcesh:master Nov 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-70-job-tojson at 87.5%
Details
@manast

This comment has been minimized.

Copy link
Contributor

manast commented Nov 21, 2019

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@manast manast added the released label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.