This change allows the work week to start on any day - this is 0-based starting with Sunday.
Not sure if this would be useful for anyone else, but I need to get my status in to my manager on Thursday so that they can get their status consolidated and up the management chain on time. This way I can view the project based on a Thursday week start.
Remove weekStartsMonday and weekStartsSunday and replace with weekSta…
This change allows the work week to start on any day - this is 0-based
starting with Sunday.
This is not backwards compatible! Default must stay on Monday.
Same here. Default must remain on Monday.
Please fix this.
You cannot break backwards compatibility. The old keywords must still be supported. There is a mechanism to deprecate them over time.
Great work! Thanks for adding this feature. However, there is one big problem left. You cannot generate a report with the correct week number in the header. The strftime parameters %W and %U are not useful here. I have no idea how to work around this. That's why TJ did not support arbitrary week starting days.
Yeah, this is definitely not something I expected to get pulled in directly, but threw out here as a question - does it make sense to try to develop this further so it can get into the mainline codebase. It seems like the answer is yes if we can figure out a way to make the correct week number work (all the other comments are easily fixable) - I'll see if I can figure something out about the week number question.
I'm definitely open to pulling this into mainline. If it's backwards compatible and does not have rough edges (like the week number issue) I'm all for it.
This is definitely a back-burner task for me, but I'll try to get back to it relatively soon. Thanks!
This seems like a good one, any news on an update?