Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropTypes has been moved to a separate package #33

Closed
AndrewJack opened this issue Jul 11, 2017 · 6 comments
Closed

PropTypes has been moved to a separate package #33

AndrewJack opened this issue Jul 11, 2017 · 6 comments

Comments

@AndrewJack
Copy link

AndrewJack commented Jul 11, 2017 •
edited

React 15.5 and later have moved PropTypes to a separate package

Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead.

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes

Does this library require the outdated version of react native or has an update never been required?

If so can we update it?
@bleonard
Copy link
Contributor

Happy to accept that PR. We're not fully up to date and haven't had to do it yet.

@brunocascio
Copy link
Contributor

I've just added a PR: #34

@AndrewJack
Copy link
Author

Ah thanks!

@aforty
Copy link

aforty commented Sep 29, 2017 •
edited

Can we merge #34 and update the package?

@CaryLandholt
Copy link

react 16 is out and this package breaks due to PropTypes being removed

@fbartho
Copy link
Contributor

fbartho commented Nov 15, 2018

Fixed in #34

@fbartho fbartho closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bleonard @fbartho @aforty @AndrewJack @CaryLandholt @brunocascio