Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Added support for Expo web #58

Open
wants to merge 3 commits into
base: master
from

Conversation

@EvanBacon
Copy link

EvanBacon commented Mar 20, 2019

The default ReactNative export was removed from the most recent version of react-native-web. Using babel-preset-expo will provide the correct babel config on web and native. This is needed for getting react-native-gifted-chat working in web.

@EvanBacon

This comment has been minimized.

Copy link
Author

EvanBacon commented Mar 21, 2019

@bleonard could you please review this

@xcarpentier

This comment has been minimized.

Copy link

xcarpentier commented Jul 15, 2019

Please, we need it for this:
FaridSafi/react-native-gifted-chat#1284
@bleonard @fbartho @jrichardlai
Thanks ;)

@xcarpentier

This comment has been minimized.

Copy link

xcarpentier commented Sep 19, 2019

Any news?

babel.config.js Show resolved Hide resolved
babel.config.js Show resolved Hide resolved
@@ -5,12 +5,7 @@
'use strict';

import React from 'react';
import ReactNative from 'react-native';

This comment has been minimized.

Copy link
@fbartho

fbartho Oct 1, 2019

Collaborator

Are there any significant changes in this file that need to be reviewed? Most of them look like Formatting changes.

This comment has been minimized.

Copy link
@EvanBacon

EvanBacon Oct 25, 2019

Author

The default export of react-native has been removed from web and will be removed from native soon. I opened this PR right after deleting it. It was removed because it causes all of the RN module to be bundled regardless of if you are using them or not.

@@ -1,5 +1,5 @@
import React from 'react';
import ReactNative from 'react-native';

This comment has been minimized.

Copy link
@fbartho

fbartho Oct 1, 2019

Collaborator

Are there any significant changes in this file that need to be reviewed? Most of them look like Formatting changes.

This comment has been minimized.

Copy link
@EvanBacon

EvanBacon Oct 25, 2019

Author

The default export of react-native has been removed from web and will be removed from native soon. I opened this PR right after deleting it. It was removed because it causes all of the RN module to be bundled regardless of if you are using them or not.

@acidhax

This comment has been minimized.

Copy link

acidhax commented Oct 25, 2019

bump

@fbartho

This comment has been minimized.

Copy link
Collaborator

fbartho commented Oct 25, 2019

@acidhax my questions are still unanswered. It feels like there are a few too many changes in this PR for what it claims to be doing, and I would prefer more documentation or explanations so that reviewers can verify this works correctly.

I’m currently not inclined to merge this PR as is, but if @EvanBacon wants to update it, or if somebody else can make a more targeted/verifiable PR then we might be able to assess this further.

@fbartho

This comment has been minimized.

Copy link
Collaborator

fbartho commented Nov 18, 2019

Thanks for your changes @EvanBacon -- I'm going to try to get this merged this week.

@xcarpentier

This comment has been minimized.

Copy link

xcarpentier commented Nov 22, 2019

any news?

@xcarpentier

This comment has been minimized.

Copy link

xcarpentier commented Dec 3, 2019

babel.config.js Outdated Show resolved Hide resolved
Copy link
Collaborator

fbartho left a comment

Thanks @radekcy! Are there any other changes that might be needed?

Co-Authored-By: Frederic Barthelemy <git@fbartho.com>
@radekcy

This comment has been minimized.

Copy link

radekcy commented Jan 15, 2020

@fbartho no I haven't encountered any other issues - could it be merged soon?

@RoninSTi

This comment has been minimized.

Copy link

RoninSTi commented Jan 22, 2020

Can this please be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.