New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDAV: Support for categories #635

Open
jelmer opened this Issue Mar 10, 2018 · 18 comments

Comments

Projects
None yet
7 participants
@jelmer
Copy link

jelmer commented Mar 10, 2018

It would be great if the CalDAV syncer could synchronize the CATEGORIES field; this seems to match quite well with the current Categories field in tasks.

@abaker abaker added the CalDAV label Mar 10, 2018

@jelmer

This comment has been minimized.

Copy link

jelmer commented Mar 18, 2018

It looks like this will require some (minor) modifications to ical4android, since it currently does not support parsing categories for tasks: https://gitlab.com/bitfireAT/ical4android/blob/master/src/main/java/at/bitfire/ical4android/Task.kt

@HerHde

This comment has been minimized.

Copy link

HerHde commented Jul 4, 2018

I've just opened a request at the developer's forum.

@layanto

This comment has been minimized.

Copy link

layanto commented Jul 28, 2018

Noticed Hide Until also doesnt sync via caldav. Any other fields not synced?

@layanto

This comment has been minimized.

Copy link

layanto commented Jul 30, 2018

Having used Tasks for a few days on my phone and tablet, I don't think caldav sync alone is enough. To me, everything I do with Tasks on my phone should be synchronised with my tablet and vice versa. This includes Filters, Settings (such as default list), etc. Unless these can be stored in a hidden VTODO which does get synchronised via caldav?

@jelmer

This comment has been minimized.

Copy link

jelmer commented Jul 31, 2018

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Nov 24, 2018

this sounds kind-of promising? dmfs/opentasks#14 (comment)

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Dec 3, 2018

This is a helpful writeup about what would be required to get CATEGORIES on the road: https://forums.bitfire.at/topic/1785/add-missing-task-properties/8

@Tie-fighter

This comment has been minimized.

Copy link

Tie-fighter commented Dec 30, 2018

Can you help me understand this issue, @ccoenen?

@rfc2822 says in bitfire's ical4android forum that ical4j does not implement the CATEGORIES-property. I found a property called CATEGORIES here so I am confused what is missing...

ical4android clearly lacks the CATEGORIES-property as stated in the ical4android forum

I use Tasks and nextcloud, so I wouldn't know anything about opentasks.
What is required to sync categories (tags)?

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Dec 30, 2018

And it has been there for 14 years! https://github.com/ical4j/ical4j/blame/4b79c1ed28b6f6ed251e936fa9a32a994eff791b/src/main/java/net/fortuna/ical4j/model/Property.java#L263 (probably longer, given that it is part of the "initial public commit".

Sadly, I can't really help, I'm neither an expert on ical4android nor on tasks. I just know that as of now "it doesn't work", and I would assume that the ball is in ical4android's corner (but I'm not sure!).

@jelmer

This comment has been minimized.

Copy link

jelmer commented Dec 31, 2018

There are indeed some references to CATEGORIES in ical4android, but it doesn't expose an API for accessing and manipulating the categories field that tasks can use.

@Tie-fighter

This comment has been minimized.

Copy link

Tie-fighter commented Dec 31, 2018

@Tie-fighter

This comment has been minimized.

Copy link

Tie-fighter commented Dec 31, 2018

@HerHde What's the relevance of RFC 7986?

@bmaehr

This comment has been minimized.

@bmaehr

This comment has been minimized.

Copy link

bmaehr commented Jan 1, 2019

Changes in

And it has been there for 14 years! https://github.com/ical4j/ical4j/blame/4b79c1ed28b6f6ed251e936fa9a32a994eff791b/src/main/java/net/fortuna/ical4j/model/Property.java#L263 (probably longer, given that it is part of the "initial public commit".

Sadly, I can't really help, I'm neither an expert on ical4android nor on tasks. I just know that as of now "it doesn't work", and I would assume that the ball is in ical4android's corner (but I'm not sure!).

https://git.bmaehr.com/open-source/ical4android/commit/e36207bb64ce6f47da6d4d83b535c5ce3a85109d

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Jan 1, 2019

I took the liberty of linking to this second changeset in the bitfire forums, this change really needs to go upstream (i.e. there).

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Jan 1, 2019

@bmaehr there was a request regarding your change in the forums: https://forums.bitfire.at/topic/1785/add-missing-task-properties/11 (i'm just linking to it here, so the info does not get lost)

@HerHde

This comment has been minimized.

Copy link

HerHde commented Jan 4, 2019

@Tie-fighter I've shoul wrote up front why RFC 7986... From what I remember now it's color, image etc. just for the sake of complete compatibility.

@ccoenen

This comment has been minimized.

Copy link

ccoenen commented Jan 14, 2019

@bmaehr did you see the request regarding AndroidEvent? It's over in the bitfire forum, I quote it here for easier reference, but over there it also features links to the relevant code sections:

AndroidEvent should be modified, too, because otherwise, DAVx⁵ would lose functionality: Now, CATEGORIES are saved in Event.unknownProperties, which are saved to the Android DB by AndroidEvent. So, DAVx⁵ saves and restores CATEGORIES at the moment as "unknown properties" without knowing anything about what CATEGORIES is and does.

As soon as Event understands CATEGORIES, they're not being put to Event.unknownProperties anymore, so AndroidEvent doesn't save/restore CATEGORIES anymore. The same applies to Task and AndroidTask.

So, if you could create a merge request for ical4android (soon: ical4x⁷), I'd merge it to a separate branch so that CATEGORIES can be implemented in AndroidEvent/AndroidTask, too before merging it to master.

(from: https://forums.bitfire.at/topic/1785/add-missing-task-properties )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment