Breaks downloads

[rugk]

I've been investigating a Firefox issue and it turned out your addon was causing it. If I have to guess, you somehow do not close/finish a request when it is cancelled or so…

So here are the full details, STR and so on: https://bugzilla.mozilla.org/show_bug.cgi?id=1480745

This is a very annoying minor bug that you'll get annoyed about each time you see it. 😄

[tasn]

Thanks for reporting. I can't believe this is an issue with signed pages, it was annoying me too! :)

I'll try to figure it out, thanks for reporting!

[rugk]

Well… just disable the add-on and it works again, immediately. 😆

[tasn]

💔

[rugk]

This is really critical, as I just noticed…
In Firefox 69.0.1 it often breaks long-running (or big file?) downloads and I get this error:

/tmp/.../....part cannot be saved, because the source file cannot be read.

Originally reported at https://bugzilla.redhat.com/show_bug.cgi?id=1758895

[tasn]

Oh, thanks for the update!
Having just reviewed the code following your report there's indeed a problem. It seems like we just try to process and validate any "main_frame", though downloads (and icons?) can also be ones.
While reviewing the code I also spotted a few other issues:

1. ondata may be called more than once (e.g. partial data every time) - we need to address that.
2. We need to make sure the response is a utf-8 one rather than binary before we decide to process it - need to verify how this should be done exactly. This should fix this issue.

Are you able to consistently reproduce the download issue? If so, are you able to test a potential workaround?

[tasn]

Also, are you able to provide a link that fails? Or show the extension's output log? (Tools -> Web developer -> browser console)

[rugk]

Also maybe fix that TODO lol:

webext-signed-pages/src/background.js

Line 116 in 696d6d0

// FIXME: Only filter pages that we care about, the rest can skip this.

When the signature is not found, you can also add an if to return early instead of still decoding the text…

[rugk]

Maybe something like #23??

[tasn]

From #23: Could you please try if this branch fixes it for you: https://github.com/tasn/webext-signed-pages/tree/early-abort

I added an early abort in case we shouldn't check a page.

[rugk]

Do you have a prebuild ZIP or so?

[tasn]

I can upload something, but it won't be signed so you won't be able to install it. I can release a new version soon, as I already tested it myself and at the very least there are no regressions.

…

On Wed, 9 Oct 2019, 19:09 rugk, ***@***.***> wrote: Do you have a prebuild ZIP or so? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AAA2Q7SWV7SUJA6PL6TUGE3QNX62NA5CNFSM4FZPQXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAYNOUY#issuecomment-540071763>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA2Q7TYFF72NNVCEBJVJXLQNX62NANCNFSM4FZPQXOQ> .

[rugk]

Yeah, I can use about:debugging. That's easy…

[tasn]

Try this: signed_pages-0.4.1.zip

[rugk]

Hmm… could not reproduce the issue anymore right now… 🤔
But I guess it is fine… 😉

[tasn]

Released a new version.