A little more padding on the homepage #2

Merged
merged 1 commit into from Mar 29, 2013

Conversation

Projects
None yet
5 participants
@stephenplusplus
Member

stephenplusplus commented Mar 29, 2013

This is just a silly PR, but I thought you might want it anyway. It adds equal padding to the top and bottom of <body>, so things are vertically, visually pleasing :)

I hadn't heard of TasteJS until about 20 minutes ago, and I can't help but be intrigued. Is there anything you guys need help with? Styling, writing (JS or copy), or general grunt work all sounds fun to me!

main.css
@@ -22,10 +22,11 @@ body {
-webkit-font-smoothing: antialiased;
color: #c5c5c5;
text-align: center;
+ padding: 50px 0;

This comment has been minimized.

Show comment Hide comment
@paulmillr

paulmillr Mar 29, 2013

Contributor

needs tabs instead of spaces

@paulmillr

paulmillr Mar 29, 2013

Contributor

needs tabs instead of spaces

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Mar 29, 2013

Owner

@stephenplusplus thanks :)

We're always more than happy to receive help. There's the open issues over at the TodoMVC repo, but there's a lot else to do too.

@passy @addyosmani maybe we should open a meta ticket with some smaller grunt work we need help to and suggestions, like tweaking, grammar, proof-reading, brainstorming, bug triaging, design, improvement suggestions, etc. Lot's of the issues in the tracker can be a bit daunting. Li

Owner

sindresorhus commented Mar 29, 2013

@stephenplusplus thanks :)

We're always more than happy to receive help. There's the open issues over at the TodoMVC repo, but there's a lot else to do too.

@passy @addyosmani maybe we should open a meta ticket with some smaller grunt work we need help to and suggestions, like tweaking, grammar, proof-reading, brainstorming, bug triaging, design, improvement suggestions, etc. Lot's of the issues in the tracker can be a bit daunting. Li

@passy

This comment has been minimized.

Show comment Hide comment
@passy

passy Mar 29, 2013

Member

@stephenplusplus Awesome! We would definitely appreciate help with those tasks.

@sindresorhus Agreed. Let's do that!

Member

passy commented Mar 29, 2013

@stephenplusplus Awesome! We would definitely appreciate help with those tasks.

@sindresorhus Agreed. Let's do that!

@stephenplusplus

This comment has been minimized.

Show comment Hide comment
@stephenplusplus

stephenplusplus Mar 29, 2013

Member

@paulmillr spaces no more!

Excuse my ignorance, but what is TasteJS? :-) After searching around, I've been able to conclude it's a TodoMVC substitute, with thicker sample applications.

I'm happy to check out some of the issues on TodoMVC, but I'm still confused if it's about to be stomped on by TasteJS. The tagline on the site-- A better JavaScript learning experience-- makes me think there's more to it than sample apps.

If there's a "What is TasteJS?" post I missed, or other resources, I'd love to see them so I can get up to speed. I don't mean to rush everyone if it's not ready yet. Just wanted to have a better understanding of the goals of this project :)

Member

stephenplusplus commented Mar 29, 2013

@paulmillr spaces no more!

Excuse my ignorance, but what is TasteJS? :-) After searching around, I've been able to conclude it's a TodoMVC substitute, with thicker sample applications.

I'm happy to check out some of the issues on TodoMVC, but I'm still confused if it's about to be stomped on by TasteJS. The tagline on the site-- A better JavaScript learning experience-- makes me think there's more to it than sample apps.

If there's a "What is TasteJS?" post I missed, or other resources, I'd love to see them so I can get up to speed. I don't mean to rush everyone if it's not ready yet. Just wanted to have a better understanding of the goals of this project :)

paulmillr added a commit that referenced this pull request Mar 29, 2013

Merge pull request #2 from stephenplusplus/master
A little more padding on the homepage

@paulmillr paulmillr merged commit ff626b5 into tastejs:master Mar 29, 2013

@paulmillr

This comment has been minimized.

Show comment Hide comment
@paulmillr

paulmillr Mar 29, 2013

Contributor

The project is not started yet, we’re in spec review state, and then we can start implementing stuff. At least one implementation is ready.

You’re right, this is TODOMVC substitute.

Contributor

paulmillr commented Mar 29, 2013

The project is not started yet, we’re in spec review state, and then we can start implementing stuff. At least one implementation is ready.

You’re right, this is TODOMVC substitute.

@stephenplusplus

This comment has been minimized.

Show comment Hide comment
@stephenplusplus

stephenplusplus Mar 31, 2013

Member

@paulmillr I'll just look forward to the ticket that @sindresorhus mentioned :)

Member

stephenplusplus commented Mar 31, 2013

@paulmillr I'll just look forward to the ticket that @sindresorhus mentioned :)

@addyosmani

This comment has been minimized.

Show comment Hide comment
@addyosmani

addyosmani Mar 31, 2013

Owner

TasteJS is the next phase of the TodoMVC project. We're going to continue working on TodoMVC, but we all acknowledge that it has it's limitations when it comes to facilitating comparisons for frameworks that help building complex apps. As @paulmillr mentioned, we're still in a spec review state.

Owner

addyosmani commented Mar 31, 2013

TasteJS is the next phase of the TodoMVC project. We're going to continue working on TodoMVC, but we all acknowledge that it has it's limitations when it comes to facilitating comparisons for frameworks that help building complex apps. As @paulmillr mentioned, we're still in a spec review state.

@stephenplusplus

This comment has been minimized.

Show comment Hide comment
@stephenplusplus

stephenplusplus Mar 31, 2013

Member

I'd like to contribute to the project, whether it's still a spec, ready for design, or launched. I'm just putting my name in front of everyone for consideration. Helping people help people is what I do, and I'd enjoy the chance to learn from the best 👍

Member

stephenplusplus commented Mar 31, 2013

I'd like to contribute to the project, whether it's still a spec, ready for design, or launched. I'm just putting my name in front of everyone for consideration. Helping people help people is what I do, and I'd enjoy the chance to learn from the best 👍

@paulmillr

This comment has been minimized.

Show comment Hide comment
@paulmillr

paulmillr Mar 31, 2013

Contributor

We will start really soon and you will be able to contribute with us. There will be a lot of work! We just need to get initial consensus on stuff.

Contributor

paulmillr commented Mar 31, 2013

We will start really soon and you will be able to contribute with us. There will be a lot of work! We just need to get initial consensus on stuff.

@stephenplusplus

This comment has been minimized.

Show comment Hide comment
@stephenplusplus

stephenplusplus Mar 31, 2013

Member

Thanks everyone, and good luck in the final stages of prep. Speaking for me and several others, I'm sure, we're very excited to see what you've all been working on!

Member

stephenplusplus commented Mar 31, 2013

Thanks everyone, and good luck in the final stages of prep. Speaking for me and several others, I'm sure, we're very excited to see what you've all been working on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment