Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: tastejs/todomvc
base: c391f51808
head fork: tastejs/todomvc
compare: 037052bc3a
Checking mergeability… Don't worry, you can still create the pull request.
Commits on Jan 18, 2012
@boushley boushley Updating index.html to match template. a9468fb
Commits on Jan 19, 2012
@boushley boushley Updated backbone implementation.
Updated backbone to 0.5.3 and jquery to 1.7.1.
Updated application to follow the new tempalte.
@boushley boushley Removing tooltip from implementation.
Also removed the destory.png image since it is no longer needed.
Commits on Jan 21, 2012
@boushley boushley Removed bindall usage in favor of passing context to bind. 842d1df
Commits on Feb 01, 2012
@boushley boushley Updating the credit. 36aaa2f
Commits on Feb 17, 2012
@boushley boushley Merge branch 'master' into backbone
Commits on Feb 27, 2012
@boushley boushley Merge branch 'master' into backbone de0428e
@boushley boushley Upgraded libs. Resolving other issues.
Bolding items left.
Trim todo input and prevent whitespace only todos.
Change content to title in model.
Double click on item div instead of just title.
Removed unused jslitmus.js.
@boushley boushley Implement removal of items when blanked on edit. 8f9ee83
@boushley boushley Converting from spaces to tabs. b0624d3
Commits on Apr 29, 2012
@addyosmani addyosmani Initial changes to bring application up to spec. 2b46d3e
Commits on May 31, 2012
@everett-sochowski everett-sochowski Use html escaping in the underscore templates ce405e7
Commits on Jun 03, 2012
@sindresorhus sindresorhus Merge pull request #175 from everett-sochowski/html_escaping
Html escaping of Backbone underscore template
@everett-sochowski everett-sochowski Fixed escaped control structures a36303d
@sindresorhus sindresorhus Merge pull request #177 from everett-sochowski/html_escaping
Html escaping
Commits on Jun 10, 2012
@loicknuchel loicknuchel add knockoutjs_require b32ef3c
Commits on Jun 17, 2012
@petermichaux petermichaux use built maria.js file and organize files according to framework's r…
…ecommended best practices
Commits on Jun 19, 2012
@stas stas Move specs runner/initializer to a separate file. ea6780d
@stas stas Move some of the views to separate files.
Initialize controller views upon `init`.
@stas stas Use latest ember.js, add basic routing support. df296b9
Commits on Jun 20, 2012
@stas stas Cleanup entries controller from hacks. 59d518a
@stas stas Correct the order of the clear button view append. ae539e5
@stas stas Rewrite clear button view to use the new `action` helper. 22ffae5
@stas stas Rewrite the items view.
Cleanup `Ember.CollectionView` template, on editing use a contextual view.
Fix race condition issue with focusOut/insertNewline when editing last item.
@stas stas Cleanup todos controller. 42e46b5
Commits on Jun 22, 2012
@richardharrington richardharrington fixed loss of context for 'this' keyword when AppView instance method…
… addAll calls AppView instance method addOne (in the backbone app).
Commits on Jun 23, 2012
@stas stas Update application initialization to make use of `ApplicationControll…
…er` and `ApplicationView`.

Initialize entries controller upon application creation, to be passed later as content property.
@stas stas Update todos controller to initalize secondary views upon content att…
…ribute setup.

TODO: Refactor this to be part of `ApplicationView` as child views.
@stas stas Update items view bindings. 8125e6a
@stas stas Router now implements `connectOutlets` method.
Renders items on root path.
@stas stas Cleanups. e9c6524
@stas stas Move main html parts to `ApplicationView` as a `ContainerView`.
Most of the non-dynamic (from routing point of view) views should reside in application view.
@stas stas Update stats view bindings and force view scope (might be an Ember bug). 920eaf3
@stas stas Update clear button view bindings. Force the view scope. 52522d2
@stas stas Hide #main and #footer elements. Do it the Ember way! 45a30e3
@stas stas Cleanups. 127c55a
@stas stas Add routing support by setting a context filter.
`TodosController` will filter the content based on router's filter.
Commits on Jun 24, 2012
@addyosmani addyosmani Merge pull request #194 from richardharrington/backbone
fixed a loss of context for 'this' keyword in backbone app
@sindresorhus sindresorhus Minor readme improvements 8d9a17f
@sindresorhus sindresorhus Readme tweak 7a72427
@addyosmani addyosmani Adding routing, fixes to footer/counter. 3e9a320
@sindresorhus sindresorhus Spine app: Autofocus new todo input on load 2c9508c
Commits on Jun 30, 2012
@stas stas Fix clear button element id. 3c11ce7
@stas stas Add jasmine to assets. 7b280ae
@stas stas Replace mocha and chai with jasmine. 814755e
@stas stas Remove mocha and chai libs. a8f4b4d
@stas stas Add a set of specs for checking todos cration, completion and deletio…
…n. See #200
Commits on Jul 01, 2012
@addyosmani addyosmani Merge pull request #198 from stas/emberjs-routing
Emberjs routing
@addyosmani addyosmani Changes to fix done -> completed 15c813f
@IgorMinar IgorMinar AngularJS: unifying indentation and ws

- Never mix spaces and tabs.
- ...  choose between soft indents (spaces) or real tabs, consider this law.

I went with spaces everywhere.
@IgorMinar IgorMinar AngularJS 1.0.1 4bcb50f
@IgorMinar IgorMinar AngularJS: cleanup + fixes
- simplified the code
- break up the code base into one file per component
- extract persistence into a separate module
- general cleanup
@IgorMinar IgorMinar AngularJS: add angularjs-perf version
this one has better performance at the cost of complexity

for a toy app like this one the difference is insignificant,
but it might be good to see the two versions and compare them
and based on that be able to make the trade-offs in real apps

the angularjs version does deep watching of the todos array object.
that means that it keeps an in memory copy of the whole array that
is used for dirty checking in order to detect model mutations. For
toy app like this it's totally fine and in fact encouraged practice
since you are trading off a little bit of memory and performance
for simplicity.

However in a large project where you are dealing with array of 100s
or 1000s of large objects you definitely don't want to use this
approach. Instead you want to use a different way of doing the same
thing, which requires more code but is a lot more efficient.
@addyosmani addyosmani First set of fixes for model level routing. 9fd0c4f
@sindresorhus sindresorhus Merge pull request #191 from IgorMinar/angularjs-fixes
Angularjs fixes
@sindresorhus sindresorhus Merge pull request #187 from petermichaux/master
use built maria.js file and organize files according to framework's recommended best practices
@addyosmani addyosmani Completing routing changes. 4cab065
@addyosmani addyosmani Finalizing application split up, cleaning up. 5d3afcf
@addyosmani addyosmani Adding fix to enable dynamic filtering 2106848
@addyosmani addyosmani Fixing dynamic filtering issue post split. 90efaca
@addyosmani addyosmani Fixing clear completed c296715
@addyosmani addyosmani Remove stray console.log dfa02a7
@addyosmani addyosmani Brace, !== fixes. 285035c
@addyosmani addyosmani libs -> lib, updating paths cc2bc4f
@addyosmani addyosmani Fix for all filter not correctly highlighting on app load a3d93c0
@addyosmani addyosmani Adding ENTER_KEY const 0973491
Commits on Jul 02, 2012
@sindresorhus sindresorhus Merge pull request #184 from loicknuchel/master
Add knockoutjs with require.js in labs
@sindresorhus sindresorhus Move ExtJS to labs 32f9bd2
@sindresorhus sindresorhus ExtJS: Minor cleanup 292026b
@sindresorhus sindresorhus ExtJS: Tab indentation a053160
@addyosmani addyosmani Switching to the latest version of dependencies, fixing routing bug a…
…fter the update.
@addyosmani addyosmani fixing escaped templates. 64b5315
@addyosmani addyosmani Template fix. 1ff6f04
@passy passy Added AMD version of angularjs-perf using require.js
Controllers and directives share a common app namespace, which is an angular
module that is loaded via require.js. The angular-loader is inlined so the
loading of angular.js and the modules can happen in parallel.
@passy passy Improvements, switch to angular base version
- Strict mode
- Split up directives
- Require 'app' in 'main' to improve loading time
- Added Igor to contributors list
@addyosmani addyosmani Updating to rewritten Backbone app. 5848399
Commits on Jul 03, 2012
@passy passy Whitespace, upstream fixes d164737
@IgorMinar IgorMinar Close GH-205: Angularjs fixes2. Fixes #191 cca0ef2
@sindresorhus sindresorhus Merge pull request #195 from passy/angular-requirejs
angular.js with require.js
@sindresorhus sindresorhus Remove Angular+Persistencejs as discussed in #201
Will be linked to in the wiki