Maria.js implementation #183

Closed
addyosmani opened this Issue Jun 8, 2012 · 20 comments

Projects

None yet

4 participants

@addyosmani
Member

I was just testing Peter Michaux's Maria MVC framework and he appears to now have a TodoMVC 0.5 compatible app in place at https://github.com/petermichaux/maria. I think we could take this further with the new template and have something ready for v1.0 or v1.1 (depending on how much time we have).

@sindresorhus
Member

@addyosmani I agree, 1.0 as long as it doesn't delay it, otherwise just defer it to 1.1

@petermichaux Would you be interested in making the app adhere to our template and App Spec?

@petermichaux
Contributor

I've been using the app spec while developing my to-do application example.

I don't know what you mean by "adhere to our template". I've been using the Backbone example for additional information. The primary change I've made is to stop using id attributes for HTML elements and use class attributes instead to find elements. This is an important change so that multiple views can be used in the same page.

@sindresorhus
Member

@petermichaux Goodie :)

I was thinking mostly about using the HTML structure from the template and using our CSS, which in your case you're going to need to modify a bit to support classes where needed. Also implement missing functionality, like saving empty todos removes them, etc.

Ya, I know IDs can be bad. Had I only known that when I created the template... We'll eventually convert, but it's far from a top priority at the moment.

Anyway, thanks for creating the app. Would you also be willing to update it with correct HTML and CSS?

@petermichaux
Contributor

I am willing to update parts of the HTML and CSS if I know what is required. Can you describe specific changes needed?

I'd like to avoid changing to using ID attributes because I don't want to advertise that as a recommended way to work with Maria. I've spent a lot of energy over the years encouraging people to change to using classes instead.

@sindresorhus
Member

Sure:

  • Read the App Spec thoroughly. It will succinctly show you our requirements and what needs to be done.
  • Try out one of our other apps, like the Spine app, and see how it looks and works. You'll see that yours is close to our current app with some differences.
  • The app needs to be visually identical to our existing apps. Since you don't want to use IDs, you're doing to need to diverge from the app spec and copy the base.css file from the assets folder into your app, and use that instead of todos.css. Do the required ID to class changes and use this CSS instead, but please follow our naming scheme.
  • Make sure your HTML is mostly the same as in the template (with exception of classes instead of IDs).

Let me know if you have any questions :)

@addyosmani
Member

For my talk last week I pulled in a version of the Maria.js todo app into labs. If we can update that one or replace with a version covering the above, I would love to have it in for the 1.0 release.

@petermichaux
Contributor

Please see my pull request.

#187

@addyosmani
Member

As we have a Maria app that landed in labs following our specs, I'm closing this. If we need to update for a future release, I'm sure we'll be pinging @petermichaux again :)

@addyosmani addyosmani closed this Sep 2, 2012
@sindresorhus
Member

@addyosmani Actually the one we have doesn't follow our app spec.

@petermichaux Would really like to get something matching our template, for beauty and comparisons purposes.

@sindresorhus sindresorhus reopened this Sep 2, 2012
@addyosmani
Member

Thanks for catching, @sindresorhus!

@sindresorhus
Member

@petermichaux We're shooting for a release soon and would really like your app to look as pretty as the rest. Would you have time to do the necessary changes?

@addyosmani
Member

A friendly ping in case you have time, Peter :)

@petermichaux
Contributor

Thank you, gentlemen. I will get to this eventually. :-)

@petermichaux
Contributor

Are the app specs on the following page still up-to-date and accurate?

https://github.com/addyosmani/todomvc/wiki/App-Specification

Thanks.

@addyosmani
Member

Yes they should be :)

@sindresorhus
Member

Yes

@petermichaux
Contributor

The new version of TodoMVC app is much simplified. I updated the Maria to use the new template and the change was quite easy. I'll put some polish on the example and hopefully Maria can move from "labs" to "stable" soon.

@petermichaux
Contributor

Pull request sent.

#352

@petermichaux
Contributor

@addyosmani informed me by email that the TodoMVC team discussed the Maria app's status and is still discussing what will be done and required for all apps regarding model level filtering before the next major release of TodoMVC. I will be happy to help make the necessary changes to the Maria app when other apps do the same and so that all apps are compliant. I would like to make the changes to the Maria app in a way that makes apples-to-apples comparisons as easy as possible. Without resolution to the tickets related to these filtering changes, I don't know how to proceed with the implementation.

In the mean time, I'm told that if I'm satisfied with the current Maria app implementation, it can be moved to stable status. Even though the Maria app is perhaps not 100% compliant in implementation due to the filtering issue, neither are all of the stable apps. The Maria app is compliant from the perspective of a user of the app. As a result of @addyosmani's message to me, I will prepare a pull request that moves the Maria app into the main architecture-examples directory.

@petermichaux
Contributor

I think this ticket can be closed. When more work is need for filtering another ticket can be created with more limited scope. That ticket could even be created now, I suppose.

@passy passy closed this Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment