Use .focus() instead of .select()? #203

Closed
sindresorhus opened this Issue Jul 1, 2012 · 9 comments

Comments

Projects
None yet
5 participants
@sindresorhus
Member

sindresorhus commented Jul 1, 2012

I can't remember why we started using .select() in the first place, but @IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a small part of it. select() highlights the whole text and forces me to deselect it. if I do want to select the whole thing I can just triple click on the item and then I'll get this behavior.

I think we should change it back.

@addyosmani

This comment has been minimized.

Show comment Hide comment
@addyosmani

addyosmani Jul 1, 2012

Member

+1 on changing.
On Jul 1, 2012 3:11 PM, "Sindre Sorhus" <
reply@reply.github.com>
wrote:

I can't remember why we started using .select() in the first place, but
@IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a
small part of it. select() highlights the whole text and forces me to
deselect it. if I do want to select the whole thing I can just triple click
on the item and then I'll get this behavior.

I think we should change it back.


Reply to this email directly or view it on GitHub:
addyosmani#203

Member

addyosmani commented Jul 1, 2012

+1 on changing.
On Jul 1, 2012 3:11 PM, "Sindre Sorhus" <
reply@reply.github.com>
wrote:

I can't remember why we started using .select() in the first place, but
@IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a
small part of it. select() highlights the whole text and forces me to
deselect it. if I do want to select the whole thing I can just triple click
on the item and then I'll get this behavior.

I think we should change it back.


Reply to this email directly or view it on GitHub:
addyosmani#203

sindresorhus added a commit that referenced this issue Aug 3, 2012

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Aug 3, 2012

Member

Converted all apps to use .focus, but even so, there are some that still selects the text. Need to figure out why...

The following still selects the text:

  • Dojo
  • Emberjs
  • Spine
  • YUI
  • Backbone Require
  • Knockout Require
  • Stapes
  • Stapes Require
  • Epitome
  • Soma.js
  • Backbone Marionette

Edited by arthurvr to remove deleted apps.

Member

sindresorhus commented Aug 3, 2012

Converted all apps to use .focus, but even so, there are some that still selects the text. Need to figure out why...

The following still selects the text:

  • Dojo
  • Emberjs
  • Spine
  • YUI
  • Backbone Require
  • Knockout Require
  • Stapes
  • Stapes Require
  • Epitome
  • Soma.js
  • Backbone Marionette

Edited by arthurvr to remove deleted apps.

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Dec 28, 2012

Member

@jsoverson just pinging you incase you would be interested in tackling any of these :)

Member

sindresorhus commented Dec 28, 2012

@jsoverson just pinging you incase you would be interested in tackling any of these :)

@passy

This comment has been minimized.

Show comment Hide comment
@passy

passy Mar 9, 2013

Member

Is the list still up to date?

Member

passy commented Mar 9, 2013

Is the list still up to date?

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Mar 9, 2013

Member

@passy partly. those apps is not fixed, but there has been included additional apps since then that might have the same issue.

Member

sindresorhus commented Mar 9, 2013

@passy partly. those apps is not fixed, but there has been included additional apps since then that might have the same issue.

@passy passy referenced this issue Apr 5, 2013

Closed

Enyo backbone #500

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this issue Dec 23, 2013

@arthurvr

This comment has been minimized.

Show comment Hide comment
@arthurvr

arthurvr May 14, 2015

Member

Emberjs

Seems to be working correctly for me. Can you confirm that, @sindresorhus?

Member

arthurvr commented May 14, 2015

Emberjs

Seems to be working correctly for me. Can you confirm that, @sindresorhus?

@arthurvr

This comment has been minimized.

Show comment Hide comment
@arthurvr

arthurvr Jun 7, 2015

Member

Ticked ember, then.

Member

arthurvr commented Jun 7, 2015

Ticked ember, then.

@samccone samccone modified the milestones: 1.4, 1.2 Jul 13, 2015

@arthurvr

This comment has been minimized.

Show comment Hide comment
@arthurvr

arthurvr Aug 25, 2015

Member

I never noticed it back then, but since when I ticked the ember app and removed the dropped apps, this can be closed :) Yay!

Member

arthurvr commented Aug 25, 2015

I never noticed it back then, but since when I ticked the ember app and removed the dropped apps, this can be closed :) Yay!

@arthurvr arthurvr closed this Aug 25, 2015

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Aug 25, 2015

Member

🎉🎉🎉

Member

sindresorhus commented Aug 25, 2015

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment