Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Use .focus() instead of .select()? #203

Open
sindresorhus opened this Issue · 6 comments

4 participants

@sindresorhus
Owner

I can't remember why we started using .select() in the first place, but @IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a small part of it. select() highlights the whole text and forces me to deselect it. if I do want to select the whole thing I can just triple click on the item and then I'll get this behavior.

I think we should change it back.

@addyosmani
Owner
@sindresorhus
Owner

Converted all apps to use .focus, but even so, there are some that still selects the text. Need to figure out why...

The following still selects the text:

  • Dojo
  • Emberjs
  • Spine
  • YUI
  • Backbone Require
  • Knockout Require
  • Stapes
  • Stapes Require
  • Epitome
  • Soma.js
  • Backbone Marionette

Edited by arthurvr to remove deleted apps.

@sindresorhus

@jsoverson just pinging you incase you would be interested in tackling any of these :)

@passy
Owner

Is the list still up to date?

@sindresorhus
Owner

@passy partly. those apps is not fixed, but there has been included additional apps since then that might have the same issue.

@passy passy referenced this issue
Closed

Enyo backbone #500

@gustaff-weldon gustaff-weldon referenced this issue from a commit in gustaff-weldon/todomvc
@sindresorhus sindresorhus Convert from .select() to .focus() 0e606dc
@arthurvr
Owner

Emberjs

Seems to be working correctly for me. Can you confirm that, @sindresorhus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.