Ember.js + RequireJs example doesn't work #217

Closed
pierregoudjo opened this Issue Jul 10, 2012 · 7 comments

Comments

Projects
None yet
3 participants

The Ember.js + RequireJs example avalaible on the website(todomvc.com) doesn't work. User interface doesn't appear.Tried on Chromium 18, Opera 12 and Firefox 13.

Owner

sindresorhus commented Jul 10, 2012

@stas Could you take a look at this?

Contributor

stas commented Jul 10, 2012

Someone deleted the ember-latest.js file :)

dependency-examples/emberjs_require/js/app.js#L7

Contributor

stas commented Jul 10, 2012

@sindresorhus do you want me to send a pull request or you can handle it?
https://github.com/emberjs/ember.js/downloads

Owner

sindresorhus commented Jul 10, 2012

Tried switching over to the url, and it seems something has changed in latest, since it now throws. Would be great if you could submit a pull, or send me the Ember rev you used that works ;)

Uncaught ReferenceError: Handlebars is not defined cloud.github.com/downloads/emberjs/ember.js/ember-latest.min.js:17
Uncaught TypeError: Cannot call method 'compile' of undefined js/app/views/stats.js:16
Uncaught TypeError: Cannot call method 'compile' of undefined js/app/views/filters.js:13
Uncaught TypeError: Cannot call method 'compile' of undefined js/app/views/clear_button.js:14
Uncaught Error: Load timeout for modules: text!app/templates/stats.html text!app/templates/filters.html text!app/templates/clear_button.html 
http://requirejs.org/docs/errors.html#timeout require.js:7
Contributor

stas commented Jul 10, 2012

Ok, I'll make a pull request.
Thanks.

Owner

sindresorhus commented Jul 10, 2012

Cool, thanks :)

sindresorhus added a commit that referenced this issue Jul 19, 2012

Merge branch 'master' of github.com:addyosmani/todomvc into new-site
* 'master' of github.com:addyosmani/todomvc: (133 commits)
  Add media/PR assets created by @gf3
  Updating CanJS script references to new cdn.
  Add SocketStream to readme and site
  Set up redirect of the old labs site
  Add SocketStream app
  Fix for #224 - ExtJS app incorrectly linked up
  Update batman.js library in the batman example to 0.11.0.
  Close GH-193: updated troopjs-bundle.
  Fix clear completed button being unclickable
  Update old ember.js version, replaced with the latest unreleased available.
  Add handlebar.js to dependencies. Closes #217.
  Knockout: Code style
  Knockout: Convert back to tab indentation
  Knockout: Upgrade to 2.1.0
  Knockoutjs: Move Crossroads to the assets folder
  Filter 'All' highlight by default
  Fixing lines
  Knockout - routing with crossroad js
  Fix app footer bug in Opera 12
  Disable automatic Jekyll
  ...

Conflicts:
	architecture-examples/extjs/index.html
	assets/base.css
	index.html
	site/css/main.css

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this issue Dec 23, 2013

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this issue Dec 23, 2013

Merge branch 'master' of github.com:addyosmani/todomvc into new-site
* 'master' of github.com:addyosmani/todomvc: (133 commits)
  Add media/PR assets created by @gf3
  Updating CanJS script references to new cdn.
  Add SocketStream to readme and site
  Set up redirect of the old labs site
  Add SocketStream app
  Fix for #224 - ExtJS app incorrectly linked up
  Update batman.js library in the batman example to 0.11.0.
  Close GH-193: updated troopjs-bundle.
  Fix clear completed button being unclickable
  Update old ember.js version, replaced with the latest unreleased available.
  Add handlebar.js to dependencies. Closes #217.
  Knockout: Code style
  Knockout: Convert back to tab indentation
  Knockout: Upgrade to 2.1.0
  Knockoutjs: Move Crossroads to the assets folder
  Filter 'All' highlight by default
  Fixing lines
  Knockout - routing with crossroad js
  Fix app footer bug in Opera 12
  Disable automatic Jekyll
  ...

Conflicts:
	architecture-examples/extjs/index.html
	assets/base.css
	index.html
	site/css/main.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment