Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use label elem rather than div.view elem to activate editing mode #227

Closed
MStumpp opened this Issue · 0 comments

2 participants

@MStumpp

In "App Specification" guidelines (https://github.com/addyosmani/todomvc/wiki/App-Specification) it says:

"Double-clicking the container (.view) activates editing mode..."

<div class='view'>
    <input class="toggle" type="checkbox" checked="checked">
    <label>Todo</label>
    <button class="destroy"></button>
</div>

This sometimes causes unexpected user behavior when you click a todo's complete/not complete checkbox (arrow) but you are not exactly above the checkbox (arrow), turning into editing mode then... so in my opinion, editing mode should only turn on/off when you are above a todo's title, that is the "label" element in the current version of html code.

@sindresorhus sindresorhus was assigned
@sindresorhus sindresorhus referenced this issue from a commit
@sindresorhus sindresorhus Convert almost all apps to trigger editing mode on `<label>` instead …
…of `.view`

The rest will get individual tickets.

Puh… :sweat:

Followup to #227
c603b48
@sindresorhus sindresorhus referenced this issue from a commit
@sindresorhus sindresorhus Convert almost all apps to trigger editing mode on `<label>` instead …
…of `.view`

The rest will get individual tickets.

Puh… :sweat:

Followup to #227
f11f1ac
@gustaff-weldon gustaff-weldon referenced this issue from a commit in gustaff-weldon/todomvc
@sindresorhus sindresorhus Convert almost all apps to trigger editing mode on `<label>` instead …
…of `.view`

The rest will get individual tickets.

Puh… :sweat:

Followup to #227
047a2f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.