Flight app routing #482

Closed
ameyakarve opened this Issue Mar 10, 2013 · 15 comments

Comments

Projects
None yet
5 participants

The routing has not been implemented for the flight app. You could use this amd hack of flatiron director that I am using. It exports the router object. Rest of the usage is straightforward
https://github.com/ameyakarve/BrassPlate/blob/master/webapp/app/scripts/vendor/director/director_AMD.js

Owner

addyosmani commented Apr 10, 2013

Does Flight have built-in routing yet or are folks mostly using Crossroads/Flatiron etc to bake in their own support? We have official recommendations for routing that we could apply in this case.

Owner

addyosmani commented Apr 12, 2013

Confirmed that Flight has no prescribed routing. If someone would like to implement this we will merge.

I have an amd version of flatiron director. That could be used.

On Friday, April 12, 2013, Addy Osmani wrote:

Confirmed that Flight has no prescribed routing. If someone would like to
implement this we will merge.


Reply to this email directly or view it on GitHubhttps://github.com/addyosmani/todomvc/issues/482#issuecomment-16304302
.

Owner

addyosmani commented Apr 24, 2013

@ameyakarve would you like to try putting together a PR tackling this?

Sure. Will do over the next few days.

On Thursday, April 25, 2013, Addy Osmani wrote:

@ameyakarve https://github.com/ameyakarve would you like to try putting
together a PR tackling this?


Reply to this email directly or view it on GitHubhttps://github.com/addyosmani/todomvc/issues/482#issuecomment-16959014
.

Owner

addyosmani commented May 11, 2013

ping @ameyakarve :)

Hey,
On vacation. Will do in the week

On Saturday, May 11, 2013, Addy Osmani notifications@github.com wrote:

ping @ameyakarve :)


Reply to this email directly or view it on GitHub.

Member

passy commented May 12, 2013

@ameyakarve Enjoy! 🌴

The routing seems to be working fine. It was fixed in the last PR I guess. Should have been following it properly I suppose.
Do you want me to specifically implement the routing using Director?

Contributor

BorisKozo commented Jun 25, 2013

There is a bug in current gh-pages version. If you mark some items as completed, switch to completed view and click clear completed then it switches back to the all view but doesn't update the footer OR it remains in completed view and doesn't update the todos :)

Member

passy commented Jun 25, 2013

@BorisKozo I tried to reproduce this and found a slightly different bug:

optimised

After clearing the completed items, I see the active tasks in the completed view.

Owner

sindresorhus commented Jun 25, 2013

hot 🔥

Contributor

BorisKozo commented Jun 25, 2013

This is the bug I saw too. Sorry if my description was misleading.

On Tuesday, June 25, 2013, Pascal Hartig wrote:

@BorisKozo https://github.com/BorisKozo I tried to reproduce this and
found a slightly different bug:

[image: optimised]https://f.cloud.github.com/assets/9906/702620/795edaf8-dd97-11e2-8388-91260f136f04.gif

After clearing the completed items, I see the active tasks in the
completed view.


Reply to this email directly or view it on GitHubhttps://github.com/tastejs/todomvc/issues/482#issuecomment-19974180
.

Member

passy commented Jun 25, 2013

Great, then it's only one bug we need to search for. :)

Member

passy commented Jun 29, 2013

Fixed by @stephenplusplus in cceaffa :)

Thanks, everyone! 👍

passy closed this Jun 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment