New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test work! #1288

Merged
merged 5 commits into from May 12, 2015

Conversation

Projects
None yet
3 participants
@samccone
Member

samccone commented May 6, 2015





Show outdated Hide outdated tests/package.json
@@ -0,0 +1,10 @@
{
"name": "todomvc-tests",
"private": true,

This comment has been minimized.

@arthurvr

arthurvr May 6, 2015

Member

There's no deal with including name when you make something private.

@arthurvr

arthurvr May 6, 2015

Member

There's no deal with including name when you make something private.

This comment has been minimized.

@samccone

samccone May 6, 2015

Member

:)

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 8, 2015

Member

It does seem strange that we're going to have a tests/ directory and that the actual tests aren't there but in browser-tests/.

Member

arthurvr commented May 8, 2015

It does seem strange that we're going to have a tests/ directory and that the actual tests aren't there but in browser-tests/.

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 8, 2015

Member

I don't really like the util/ directory name as well. It gives the impression that actual code lives in there. That's not really true, most people will never need these scripts.

Member

arthurvr commented May 8, 2015

I don't really like the util/ directory name as well. It gives the impression that actual code lives in there. That's not really true, most people will never need these scripts.

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus May 8, 2015

Member

Maybe:

browser-tests => test
util => tooling
tests => tooling

Member

sindresorhus commented May 8, 2015

Maybe:

browser-tests => test
util => tooling
tests => tooling

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 8, 2015

Member

Yes 👍. I wonder if we can dump that travis-runner.sh in tooling then as well?

Member

arthurvr commented May 8, 2015

Yes 👍. I wonder if we can dump that travis-runner.sh in tooling then as well?

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone May 8, 2015

Member

yeah i can drop the util folder and just make a func since it is only used in one spot

Member

samccone commented May 8, 2015

yeah i can drop the util folder and just make a func since it is only used in one spot

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone May 8, 2015

Member

travis-runner is actually a bad name now.. and can just be test-runner.sh since it will run everything :)

Member

samccone commented May 8, 2015

travis-runner is actually a bad name now.. and can just be test-runner.sh since it will run everything :)

@samccone samccone changed the title from run jscs over changes to examples to test work! May 8, 2015

Show outdated Hide outdated test-runner.sh
get_changes ()
{
git remote add current https://github.com/tastejs/todomvc.git && \

This comment has been minimized.

@arthurvr

arthurvr May 10, 2015

Member

why does this file use 2 spaces indentation?

@arthurvr

arthurvr May 10, 2015

Member

why does this file use 2 spaces indentation?

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone May 10, 2015

Member

all updated @arthurvr

Member

samccone commented May 10, 2015

all updated @arthurvr

samccone added a commit that referenced this pull request May 12, 2015

@samccone samccone merged commit 7e47a92 into master May 12, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samccone samccone deleted the sjs/run-jscs branch May 12, 2015

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr May 12, 2015

Member

Yiippeeee!

Member

arthurvr commented May 12, 2015

Yiippeeee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment